Remove symbol table lookup

Author: Razvan Lupusoru

mlir/include/mlir/Dialect/OpenACC/OpenACCOps.td

@@ -1323,7 +1323,9 @@ def OpenACC_PrivateRecipeOp
     /// PointerLikeType interface. If a type implements both, the MappableType
     /// API will be preferred. Returns std::nullopt if the recipe cannot be
     /// created or populated. The builder's current insertion point will be used
-    /// and it must be a valid place for this operation to be inserted.
+    /// and it must be a valid place for this operation to be inserted. The
+    /// `recipeName` must be a unique name to prevent "redefinition of symbol"
+    /// IR errors.
     static std::optional<PrivateRecipeOp> createAndPopulate(
         ::mlir::OpBuilder &builder,
         ::mlir::Location loc,
@@ -1433,7 +1435,9 @@ def OpenACC_FirstprivateRecipeOp
     /// PointerLikeType interface. If a type implements both, the MappableType
     /// API will be preferred. Returns std::nullopt if the recipe cannot be
     /// created or populated. The builder's current insertion point will be used
-    /// and it must be a valid place for this operation to be inserted.
+    /// and it must be a valid place for this operation to be inserted. The
+    /// `recipeName` must be a unique name to prevent "redefinition of symbol"
+    /// IR errors.
     static std::optional<FirstprivateRecipeOp> createAndPopulate(
         ::mlir::OpBuilder &builder,
         ::mlir::Location loc,

mlir/lib/Dialect/OpenACC/IR/OpenACC.cpp

@@ -1201,15 +1201,6 @@ std::optional<PrivateRecipeOp>
 PrivateRecipeOp::createAndPopulate(OpBuilder &builder, Location loc,
                                    StringRef recipeName, Type varType,
                                    StringRef varName, ValueRange bounds) {
-
-  // Check if a symbol with this name already exists in the symbol table.
-  // If it does - don't assume that we can just reuse the existing one.
-  Operation *parentOp = builder.getInsertionBlock()->getParentOp();
-  if (parentOp &&
-      SymbolTable::lookupNearestSymbolFrom(
-          parentOp, mlir::StringAttr::get(builder.getContext(), varName)))
-    return std::nullopt;
-
   // First, validate that we can handle this variable type
   bool isMappable = isa<MappableType>(varType);
   bool isPointerLike = isa<PointerLikeType>(varType);
@@ -1289,15 +1280,6 @@ std::optional<FirstprivateRecipeOp>
 FirstprivateRecipeOp::createAndPopulate(OpBuilder &builder, Location loc,
                                         StringRef recipeName, Type varType,
                                         StringRef varName, ValueRange bounds) {
-
-  // Check if a symbol with this name already exists in the symbol table.
-  // If it does - don't assume that we can just reuse the existing one.
-  Operation *parentOp = builder.getInsertionBlock()->getParentOp();
-  if (parentOp &&
-      SymbolTable::lookupNearestSymbolFrom(
-          parentOp, mlir::StringAttr::get(builder.getContext(), varName)))
-    return std::nullopt;
-
   // First, validate that we can handle this variable type
   bool isMappable = isa<MappableType>(varType);
   bool isPointerLike = isa<PointerLikeType>(varType);