Fix Windows build error and apply code formatting

- Fix unit test to pass AtomicOpValue& instead of Value* to createAtomicRead
- Apply clang-format to fix code style violations
- Remove trailing whitespace and fix indentation

Author: Krish Gupta

llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp

@@ -5473,7 +5473,8 @@ OpenMPIRBuilder::collapseLoops(DebugLoc DL, ArrayRef<CanonicalLoopInfo *> Loops,
     }
 
     // TODO: Enable UndefinedSanitizer to diagnose an overflow here.
-    CollapsedTripCount = Builder.CreateNUWMul(CollapsedTripCount, OrigTripCount);
+    CollapsedTripCount =
+        Builder.CreateNUWMul(CollapsedTripCount, OrigTripCount);
   }
 
   // Create the collapsed loop control flow.
@@ -9579,7 +9580,7 @@ Expected<std::pair<Value *, Value *>> OpenMPIRBuilder::emitAtomicUpdate(
     OldVal->setAtomic(AO);
     // CurBB
     // |     /---\
-		// ContBB    |
+    // ContBB    |
     // |     \---/
     // ExitBB
     BasicBlock *CurBB = Builder.GetInsertBlock();

llvm/unittests/Frontend/OpenMPIRBuilderTest.cpp

@@ -4548,16 +4548,16 @@ TEST_F(OpenMPIRBuilderTest, OMPAtomicRWStructType) {
                                           EntryBB->getFirstInsertionPt());
 
   LLVMContext &Ctx = M->getContext();
-  
+
   // Create a struct type {double, double} to simulate complex(8) - 16 bytes
   StructType *Complex8Ty = StructType::create(
       Ctx, {Type::getDoubleTy(Ctx), Type::getDoubleTy(Ctx)}, "complex");
-  
+
   AllocaInst *XVal = Builder.CreateAlloca(Complex8Ty);
   XVal->setName("AtomicVar");
   OpenMPIRBuilder::AtomicOpValue X = {XVal, Complex8Ty, false, false};
   AtomicOrdering AO = AtomicOrdering::SequentiallyConsistent;
-  
+
   // Create value to write: {1.0, 1.0}
   Constant *Real = ConstantFP::get(Type::getDoubleTy(Ctx), 1.0);
   Constant *Imag = ConstantFP::get(Type::getDoubleTy(Ctx), 1.0);
@@ -4571,10 +4571,8 @@ TEST_F(OpenMPIRBuilderTest, OMPAtomicRWStructType) {
   AllocaInst *VVal = Builder.CreateAlloca(Complex8Ty);
   VVal->setName("ReadDest");
   OpenMPIRBuilder::AtomicOpValue V = {VVal, Complex8Ty, false, false};
-  Value *ReadResult = nullptr;
-  
-  Builder.restoreIP(
-      OMPBuilder.createAtomicRead(Loc, X, ReadResult, AO, AllocaIP));
+
+  Builder.restoreIP(OMPBuilder.createAtomicRead(Loc, X, V, AO, AllocaIP));
 
   Builder.CreateRetVoid();
   OMPBuilder.finalize();
@@ -4583,7 +4581,7 @@ TEST_F(OpenMPIRBuilderTest, OMPAtomicRWStructType) {
   // Verify that __atomic_store and __atomic_load are called with size 16
   bool FoundAtomicStore = false;
   bool FoundAtomicLoad = false;
-  
+
   for (Function &Fn : *M) {
     if (Fn.getName().starts_with("__atomic_store")) {
       // Check that first call to __atomic_store has size argument = 16
@@ -4610,7 +4608,7 @@ TEST_F(OpenMPIRBuilderTest, OMPAtomicRWStructType) {
       }
     }
   }
-  
+
   EXPECT_TRUE(FoundAtomicStore) << "Did not find __atomic_store call";
   EXPECT_TRUE(FoundAtomicLoad) << "Did not find __atomic_load call";
 }
@@ -7657,8 +7655,7 @@ TEST_F(OpenMPIRBuilderTest, CreateTaskgroup) {
   // Checking the general structure of the IR generated is same as expected.
   Instruction *GeneratedStoreInst = TaskgroupCall->getNextNode();
   EXPECT_EQ(GeneratedStoreInst, InternalStoreInst);
-  Instruction *GeneratedLoad32 =
-      GeneratedStoreInst->getNextNode();
+  Instruction *GeneratedLoad32 = GeneratedStoreInst->getNextNode();
   EXPECT_EQ(GeneratedLoad32, InternalLoad32);
   Instruction *GeneratedLoad128 = GeneratedLoad32->getNextNode();
   EXPECT_EQ(GeneratedLoad128, InternalLoad128);