Apply suggestions from code review

Co-authored-by: Pavel Labath <[email protected]>

Author: ashgti

lldb/tools/lldb-dap/Breakpoint.cpp

@@ -7,18 +7,14 @@
 //===----------------------------------------------------------------------===//
 
 #include "Breakpoint.h"
-
 #include "JSONUtils.h"
-
 #include "lldb/API/SBAddress.h"
 #include "lldb/API/SBBreakpointLocation.h"
 #include "lldb/API/SBLineEntry.h"
-
 #include "llvm/ADT/StringExtras.h"
 #include "llvm/Support/JSON.h"
-
-#include <stddef.h>
-#include <stdint.h>
+#include <cstddef>
+#include <cstdint>
 #include <string>
 
 using namespace lldb_dap;

lldb/tools/lldb-dap/Breakpoint.h

@@ -11,7 +11,6 @@
 
 #include "BreakpointBase.h"
 #include "DAPForward.h"
-
 #include "lldb/API/SBBreakpoint.h"
 
 namespace lldb_dap {

lldb/tools/lldb-dap/BreakpointBase.cpp

@@ -7,9 +7,7 @@
 //===----------------------------------------------------------------------===//
 
 #include "BreakpointBase.h"
-
 #include "JSONUtils.h"
-
 #include "llvm/ADT/StringRef.h"
 
 using namespace lldb_dap;

lldb/tools/lldb-dap/BreakpointBase.h

@@ -10,7 +10,6 @@
 #define LLDB_TOOLS_LLDB_DAP_BREAKPOINTBASE_H
 
 #include "DAPForward.h"
-
 #include <string>
 
 namespace lldb_dap {

lldb/tools/lldb-dap/ExceptionBreakpoint.cpp

@@ -7,10 +7,8 @@
 //===----------------------------------------------------------------------===//
 
 #include "ExceptionBreakpoint.h"
-
 #include "BreakpointBase.h"
 #include "DAP.h"
-
 #include "lldb/API/SBTarget.h"
 
 namespace lldb_dap {

lldb/tools/lldb-dap/ExceptionBreakpoint.h

@@ -10,10 +10,8 @@
 #define LLDB_TOOLS_LLDB_DAP_EXCEPTIONBREAKPOINT_H
 
 #include "DAPForward.h"
-
 #include "lldb/API/SBBreakpoint.h"
 #include "lldb/lldb-enumerations.h"
-
 #include <string>
 #include <utility>
 

lldb/tools/lldb-dap/FunctionBreakpoint.cpp

@@ -7,7 +7,6 @@
 //===----------------------------------------------------------------------===//
 
 #include "FunctionBreakpoint.h"
-
 #include "DAP.h"
 #include "JSONUtils.h"
 

lldb/tools/lldb-dap/InstructionBreakpoint.cpp

@@ -8,13 +8,10 @@
 //===----------------------------------------------------------------------===//
 
 #include "InstructionBreakpoint.h"
-
 #include "DAP.h"
 #include "JSONUtils.h"
-
 #include "lldb/API/SBBreakpoint.h"
 #include "lldb/API/SBTarget.h"
-
 #include "llvm/ADT/StringRef.h"
 
 namespace lldb_dap {

lldb/tools/lldb-dap/InstructionBreakpoint.h

@@ -12,10 +12,8 @@
 
 #include "Breakpoint.h"
 #include "DAPForward.h"
-
 #include "lldb/lldb-defines.h"
 #include "lldb/lldb-types.h"
-
 #include <cstdint>
 
 namespace lldb_dap {
@@ -26,7 +24,7 @@ struct InstructionBreakpoint : public Breakpoint {
   lldb::addr_t instructionAddressReference;
   int32_t offset;
 
-  InstructionBreakpoint(DAP &d)
+  explicit InstructionBreakpoint(DAP &d)
       : Breakpoint(d), instructionAddressReference(LLDB_INVALID_ADDRESS),
         offset(0) {}
   InstructionBreakpoint(DAP &d, const llvm::json::Object &obj);

lldb/tools/lldb-dap/Watchpoint.h

@@ -11,12 +11,10 @@
 
 #include "BreakpointBase.h"
 #include "DAPForward.h"
-
 #include "lldb/API/SBError.h"
 #include "lldb/API/SBWatchpoint.h"
 #include "lldb/API/SBWatchpointOptions.h"
 #include "lldb/lldb-types.h"
-
 #include <cstddef>
 
 namespace lldb_dap {