Skip to content

Commit 4985ce1

Browse files
authored
Remove unsetenv cleanup calls from setenv tests, to be uncommented after unsetenv implementation (coming in subsequent commit)
1 parent b288ac0 commit 4985ce1

File tree

1 file changed

+18
-19
lines changed

1 file changed

+18
-19
lines changed

libc/test/integration/src/stdlib/setenv_test.cpp

Lines changed: 18 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88

99
#include "src/stdlib/getenv.h"
1010
#include "src/stdlib/setenv.h"
11-
#include "src/stdlib/unsetenv.h"
1211
#include "src/string/strcmp.h"
1312

1413
#include "test/IntegrationTest/test.h"
@@ -27,8 +26,8 @@ TEST_MAIN([[maybe_unused]] int argc, [[maybe_unused]] char **argv,
2726
ASSERT_TRUE(value != nullptr);
2827
ASSERT_EQ(LIBC_NAMESPACE::strcmp(value, "test_value"), 0);
2928

30-
// Clean up
31-
LIBC_NAMESPACE::unsetenv("SETENV_TEST_VAR");
29+
// Uncomment after unsetenv is committed
30+
// LIBC_NAMESPACE::unsetenv("SETENV_TEST_VAR");
3231
}
3332

3433
// Test: OverwriteExisting
@@ -45,8 +44,8 @@ TEST_MAIN([[maybe_unused]] int argc, [[maybe_unused]] char **argv,
4544
"replaced"),
4645
0);
4746

48-
// Clean up
49-
LIBC_NAMESPACE::unsetenv("OVERWRITE_VAR");
47+
// Uncomment after unsetenv is committed
48+
// LIBC_NAMESPACE::unsetenv("OVERWRITE_VAR");
5049
}
5150

5251
// Test: NoOverwriteFlag
@@ -69,8 +68,8 @@ TEST_MAIN([[maybe_unused]] int argc, [[maybe_unused]] char **argv,
6968
"changed"),
7069
0);
7170

72-
// Clean up
73-
LIBC_NAMESPACE::unsetenv("NO_OVERWRITE_VAR");
71+
// Uncomment after unsetenv is committed
72+
// LIBC_NAMESPACE::unsetenv("NO_OVERWRITE_VAR");
7473
}
7574

7675
// Test: NullName
@@ -110,8 +109,8 @@ TEST_MAIN([[maybe_unused]] int argc, [[maybe_unused]] char **argv,
110109
ASSERT_TRUE(value != nullptr);
111110
ASSERT_EQ(LIBC_NAMESPACE::strcmp(value, ""), 0);
112111

113-
// Clean up
114-
LIBC_NAMESPACE::unsetenv("EMPTY_VALUE_VAR");
112+
// Uncomment after unsetenv is committed
113+
// LIBC_NAMESPACE::unsetenv("EMPTY_VALUE_VAR");
115114
}
116115

117116
// Test: MultipleVariables
@@ -129,10 +128,10 @@ TEST_MAIN([[maybe_unused]] int argc, [[maybe_unused]] char **argv,
129128
ASSERT_EQ(LIBC_NAMESPACE::strcmp(LIBC_NAMESPACE::getenv("VAR3"), "value3"),
130129
0);
131130

132-
// Clean up
133-
LIBC_NAMESPACE::unsetenv("VAR1");
134-
LIBC_NAMESPACE::unsetenv("VAR2");
135-
LIBC_NAMESPACE::unsetenv("VAR3");
131+
// Uncomment after unsetenv is committed
132+
// LIBC_NAMESPACE::unsetenv("VAR1");
133+
// LIBC_NAMESPACE::unsetenv("VAR2");
134+
// LIBC_NAMESPACE::unsetenv("VAR3");
136135
}
137136

138137
// Test: LongValues
@@ -148,8 +147,8 @@ TEST_MAIN([[maybe_unused]] int argc, [[maybe_unused]] char **argv,
148147
LIBC_NAMESPACE::strcmp(LIBC_NAMESPACE::getenv(long_name), long_value),
149148
0);
150149

151-
// Clean up
152-
LIBC_NAMESPACE::unsetenv(long_name);
150+
// Uncomment after unsetenv is committed
151+
// LIBC_NAMESPACE::unsetenv(long_name);
153152
}
154153

155154
// Test: SpecialCharacters
@@ -160,8 +159,8 @@ TEST_MAIN([[maybe_unused]] int argc, [[maybe_unused]] char **argv,
160159
"!@#$%^&*()"),
161160
0);
162161

163-
// Clean up
164-
LIBC_NAMESPACE::unsetenv("SPECIAL_CHARS");
162+
// Uncomment after unsetenv is committed
163+
// LIBC_NAMESPACE::unsetenv("SPECIAL_CHARS");
165164
}
166165

167166
// Test: ReplaceMultipleTimes
@@ -182,8 +181,8 @@ TEST_MAIN([[maybe_unused]] int argc, [[maybe_unused]] char **argv,
182181
"value3"),
183182
0);
184183

185-
// Clean up
186-
LIBC_NAMESPACE::unsetenv("MULTI_REPLACE");
184+
// Uncomment after unsetenv is committed
185+
// LIBC_NAMESPACE::unsetenv("MULTI_REPLACE");
187186
}
188187

189188
return 0;

0 commit comments

Comments
 (0)