[libc++] More naming and comment changes as recommended

Author: Roger Sanders

libcxx/src/atomic.cpp

@@ -110,10 +110,10 @@ static void __libcpp_platform_wake_by_address(__cxx_atomic_contention_t const vo
 static void
 __libcpp_platform_wait_on_address(__cxx_atomic_contention_t const volatile* __ptr, __cxx_contention_t __val) {
   // WaitOnAddress was added in Windows 8 (build 9200)
-  static auto __pWaitOnAddress = reinterpret_cast<BOOL(WINAPI*)(volatile void*, PVOID, SIZE_T, DWORD)>(
+  static auto wait_on_address = reinterpret_cast<BOOL(WINAPI*)(volatile void*, PVOID, SIZE_T, DWORD)>(
       GetProcAddress(GetModuleHandleW(L"api-ms-win-core-synch-l1-2-0.dll"), "WaitOnAddress"));
-  if (__pWaitOnAddress != nullptr) {
-    __pWaitOnAddress(const_cast<__cxx_atomic_contention_t*>(__ptr), &__val, sizeof(__val), INFINITE);
+  if (wait_on_address != nullptr) {
+    wait_on_address(const_cast<__cxx_atomic_contention_t*>(__ptr), &__val, sizeof(__val), INFINITE);
   } else {
     __libcpp_thread_poll_with_backoff(
         [=]() -> bool { return !__cxx_nonatomic_compare_equal(__cxx_atomic_load(__ptr, memory_order_relaxed), __val); },
@@ -124,17 +124,23 @@ __libcpp_platform_wait_on_address(__cxx_atomic_contention_t const volatile* __pt
 static void __libcpp_platform_wake_by_address(__cxx_atomic_contention_t const volatile* __ptr, bool __notify_one) {
   if (__notify_one) {
     // WakeByAddressSingle was added in Windows 8 (build 9200)
-    static auto __pWakeByAddressSingle = reinterpret_cast<void(WINAPI*)(PVOID)>(
+    static auto wake_by_address_single = reinterpret_cast<void(WINAPI*)(PVOID)>(
         GetProcAddress(GetModuleHandleW(L"api-ms-win-core-synch-l1-2-0.dll"), "WakeByAddressSingle"));
-    if (__pWakeByAddressSingle != nullptr) {
-      __pWakeByAddressSingle(const_cast<__cxx_atomic_contention_t*>(__ptr));
+    if (wake_by_address_single != nullptr) {
+      wake_by_address_single(const_cast<__cxx_atomic_contention_t*>(__ptr));
+    } else {
+      // The fallback implementation of waking does nothing, as the fallback wait implementation just does polling, so
+      // there's nothing to do here.
     }
   } else {
     // WakeByAddressAll was added in Windows 8 (build 9200)
-    static auto __pWakeByAddressAll = reinterpret_cast<void(WINAPI*)(PVOID)>(
+    static auto wake_by_address_all = reinterpret_cast<void(WINAPI*)(PVOID)>(
         GetProcAddress(GetModuleHandleW(L"api-ms-win-core-synch-l1-2-0.dll"), "WakeByAddressAll"));
-    if (__pWakeByAddressAll != nullptr) {
-      __pWakeByAddressAll(const_cast<__cxx_atomic_contention_t*>(__ptr));
+    if (wake_by_address_all != nullptr) {
+      wake_by_address_all(const_cast<__cxx_atomic_contention_t*>(__ptr));
+    } else {
+      // The fallback implementation of waking does nothing, as the fallback wait implementation just does polling, so
+      // there's nothing to do here.
     }
   }
 }