Fix profiling of pack indexing expressions

Author: cor3ntin

clang/include/clang/AST/ExprCXX.h

@@ -4592,6 +4592,10 @@ class PackIndexingExpr final
     return {getTrailingObjects<Expr *>(), TransformedExpressions};
   }
 
+  bool isPartiallySubstituted() const {
+    return isValueDependent() && TransformedExpressions;
+  };
+
   static bool classof(const Stmt *T) {
     return T->getStmtClass() == PackIndexingExprClass;
   }

clang/lib/AST/StmtProfile.cpp

@@ -2291,9 +2291,15 @@ void StmtProfiler::VisitSizeOfPackExpr(const SizeOfPackExpr *S) {
 }
 
 void StmtProfiler::VisitPackIndexingExpr(const PackIndexingExpr *E) {
-  VisitExpr(E);
-  VisitExpr(E->getPackIdExpression());
   VisitExpr(E->getIndexExpr());
+
+  if (E->isPartiallySubstituted()) {
+    ID.AddInteger(E->getExpressions().size());
+    for (const Expr *Sub : E->getExpressions())
+      Visit(Sub);
+  } else {
+    VisitExpr(E->getPackIdExpression());
+  }
 }
 
 void StmtProfiler::VisitSubstNonTypeTemplateParmPackExpr(

clang/test/SemaTemplate/concepts-out-of-line-def.cpp

@@ -785,55 +785,71 @@ consteval void S::mfn() requires (bool(&fn)) {}
 
 namespace GH138255 {
 
-  template <typename... T>
-  concept C = true;
-
-  struct Func {
-      template<typename... Ts>
-      requires C<Ts...[0]>
-      static auto buggy() -> void;
-
-      template<typename... Ts>
-      requires C<Ts...[0]>
-      friend auto fr() -> void;
-
-      template<typename... Ts>
-      requires C<Ts...[0]>
-      friend auto fr2() -> void{}; // expected-note{{previous definition is here}}
-  };
+template <typename... T>
+concept C = true;
 
+struct Func {
   template<typename... Ts>
   requires C<Ts...[0]>
-  auto Func::buggy() -> void {}
+  static auto buggy() -> void;
 
   template<typename... Ts>
   requires C<Ts...[0]>
-  auto fr() -> void {}
+  friend auto fr() -> void;
 
   template<typename... Ts>
   requires C<Ts...[0]>
-  auto fr2() -> void {} // expected-error{{redefinition of 'fr2'}}
+  friend auto fr2() -> void{}; // expected-note{{previous definition is here}}
+};
 
+template<typename... Ts>
+requires C<Ts...[0]>
+auto Func::buggy() -> void {}
 
-  template <typename... Ts>
-  requires C<Ts...[0]>
-  struct Class;
+template<typename... Ts>
+requires C<Ts...[0]>
+auto fr() -> void {}
 
-  template <typename... Ts>
-  requires C<Ts...[0]>
-  struct Class;
+template<typename... Ts>
+requires C<Ts...[0]>
+auto fr2() -> void {} // expected-error{{redefinition of 'fr2'}}
 
 
-  template <typename...>
-  struct TplClass {
-      template<typename... Ts>
-      requires C<Ts...[0]>
-      static auto buggy() -> void;
-  };
+template <typename... Ts>
+requires C<Ts...[0]>
+struct Class;
+
+template <typename... Ts>
+requires C<Ts...[0]>
+struct Class;
+
 
-  template<>
+template <typename...>
+struct TplClass {
   template<typename... Ts>
   requires C<Ts...[0]>
-  auto TplClass<int>::buggy() -> void {}
+  static auto buggy() -> void;
+};
 
-  }
+template<>
+template<typename... Ts>
+requires C<Ts...[0]>
+auto TplClass<int>::buggy() -> void {}
+
+}
+
+namespace PackIndexExpr {
+template <int... T>
+concept C = true;
+
+template <typename...> struct TplClass {
+  template <int... Ts>
+  requires C<Ts...[0]>
+  static auto buggy() -> void;
+};
+
+template <>
+template <int... Ts>
+requires C<Ts...[0]>
+auto TplClass<int>::buggy() -> void {}
+}