Skip to content

Commit 4a22003

Browse files
committed
add note about distributed loops
Signed-off-by: Max Dawkins <[email protected]>
1 parent b44d16b commit 4a22003

File tree

1 file changed

+4
-0
lines changed
  • mlir/include/mlir/Dialect/Linalg/Transforms

1 file changed

+4
-0
lines changed

mlir/include/mlir/Dialect/Linalg/Transforms/Hoisting.h

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,10 @@ namespace linalg {
4444
///
4545
/// WARNING: This hoisting does not model parallelism and is generally incorrect
4646
/// when used on distributed loops with memref semantics!
47+
/// NOTE: Setting `verifyNonZeroTrip = true` makes this more stable for
48+
/// distributed loops with memref semantics, but there could still be some
49+
/// issues when loops are executed a different number of times for different
50+
/// threads.
4751
void hoistRedundantVectorTransfers(Operation *root,
4852
bool verifyNonZeroTrip = false);
4953

0 commit comments

Comments
 (0)