fix: remove unnecessary printQualifiedAttrOrType function

This commit removes `printQualifiedAttrOrType` function, since printing already ignores the mnemonic of the nested attribute.

Author: JueonPark

mlir/include/mlir/IR/OpImplementation.h

@@ -20,7 +20,6 @@
 #include "llvm/ADT/Twine.h"
 #include "llvm/Support/SMLoc.h"
 #include <optional>
-#include <type_traits>
 
 namespace {
 // reference https://stackoverflow.com/a/16000226
@@ -204,57 +203,6 @@ class AsmPrinter {
     *this << attrOrType;
   }
 
-  /// Print the provided attribute or type ensuring that any dialect-specific
-  /// prefixes (e.g. `#dialect.mnemonic`) are retained. This is used in
-  /// contexts, such as structured property dictionaries, where the fully
-  /// qualified form is required for disambiguation.
-  template <typename AttrOrType,
-            std::enable_if_t<std::is_convertible_v<AttrOrType, Attribute>> *
-                sfinae = nullptr>
-  void printQualifiedAttrOrType(AttrOrType attrOrType) {
-    Attribute attr = attrOrType;
-    Dialect &dialect = attr.getDialect();
-    StringRef dialectNamespace = dialect.getNamespace();
-    if (dialectNamespace.empty() || dialectNamespace == "builtin") {
-      printStrippedAttrOrType(attrOrType);
-      return;
-    }
-    printAttribute(attr);
-  }
-
-  template <typename AttrOrType,
-            std::enable_if_t<std::is_convertible_v<AttrOrType, Type> &&
-                             !std::is_convertible_v<AttrOrType, Attribute>> *
-                sfinae = nullptr>
-  void printQualifiedAttrOrType(AttrOrType attrOrType) {
-    Type type = attrOrType;
-    Dialect &dialect = type.getDialect();
-    StringRef dialectNamespace = dialect.getNamespace();
-    if (dialectNamespace.empty() || dialectNamespace == "builtin") {
-      printStrippedAttrOrType(attrOrType);
-      return;
-    }
-    printType(type);
-  }
-
-  template <typename ElementT,
-            std::enable_if_t<std::is_convertible_v<ElementT, Attribute> ||
-                             std::is_convertible_v<ElementT, Type>> *sfinae =
-                nullptr>
-  void printQualifiedAttrOrType(ArrayRef<ElementT> attrOrTypes) {
-    llvm::interleaveComma(attrOrTypes, getStream(), [&](ElementT element) {
-      printQualifiedAttrOrType(element);
-    });
-  }
-
-  template <typename AttrOrType,
-            std::enable_if_t<!std::is_convertible_v<AttrOrType, Attribute> &&
-                             !std::is_convertible_v<AttrOrType, Type>> *
-                sfinae = nullptr>
-  void printQualifiedAttrOrType(AttrOrType attrOrType) {
-    *this << attrOrType;
-  }
-
   /// Print the given attribute without its type. The corresponding parser must
   /// provide a valid type for the attribute.
   virtual void printAttributeWithoutType(Attribute attr);

mlir/tools/mlir-tblgen/AttrOrTypeFormatGen.cpp

@@ -174,8 +174,7 @@ static const char *const defaultParameterPrinter =
 
 /// Qualified printer for attribute or type parameters: it does not elide
 /// dialect and mnemonic.
-static const char *const qualifiedParameterPrinter =
-  "$_printer.printQualifiedAttrOrType($_self)";
+static const char *const qualifiedParameterPrinter = "$_printer << $_self";
 
 /// Print an error when failing to parse an element.
 ///