Skip to content

Commit 4ab2597

Browse files
committed
[orc-rt] Remove incorrect noexcept specifiers.
Conversions between Error/Expected and their serializable counterparts may throw.
1 parent 69761e7 commit 4ab2597

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

orc-rt/include/orc-rt/SPSWrapperFunction.h

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -37,12 +37,12 @@ template <typename... SPSArgTs> struct WFSPSHelper {
3737
return Arg;
3838
}
3939

40-
static SPSSerializableError toSerializable(Error Err) noexcept {
40+
static SPSSerializableError toSerializable(Error Err) {
4141
return SPSSerializableError(std::move(Err));
4242
}
4343

4444
template <typename T>
45-
static SPSSerializableExpected<T> toSerializable(Expected<T> Arg) noexcept {
45+
static SPSSerializableExpected<T> toSerializable(Expected<T> Arg) {
4646
return SPSSerializableExpected<T>(std::move(Arg));
4747
}
4848

@@ -61,12 +61,12 @@ template <typename... SPSArgTs> struct WFSPSHelper {
6161
return std::forward<T>(Arg);
6262
}
6363

64-
static Error fromSerializable(SPSSerializableError Err) noexcept {
64+
static Error fromSerializable(SPSSerializableError Err) {
6565
return Err.toError();
6666
}
6767

6868
template <typename T>
69-
static Expected<T> fromSerializable(SPSSerializableExpected<T> Val) noexcept {
69+
static Expected<T> fromSerializable(SPSSerializableExpected<T> Val) {
7070
return Val.toExpected();
7171
}
7272

0 commit comments

Comments
 (0)