Commit 4ab4992
committed
remove new over-assertive assert
I added an assert that prevents ExprType to be "trivial types" (i32, f32, ...)
but that actually breaks existing lowering code that generate as_expr + associate
patterns to create temporaries:
https://github.com/llvm/llvm-project/blob/03b5f8f0f0d10c412842ed04b90e2217cf071218/flang/lib/Lower/ConvertCall.cpp#L1271
```
subroutine trivial_as_expr(i)
integer, optional :: i
interface
subroutine foo(j)
integer, optional, value :: j
end subroutine
end interface
call foo(i)
end subroutine
```
This is unrelated to this patch, so leave it like this (it is not even a
functional problem).1 parent 2002996 commit 4ab4992
1 file changed
+0
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
220 | 220 | | |
221 | 221 | | |
222 | 222 | | |
223 | | - | |
224 | | - | |
225 | 223 | | |
226 | 224 | | |
227 | 225 | | |
| |||
0 commit comments