Skip to content

Commit 4b01113

Browse files
committed
[AMDGPU] Fix wrong MSB encoding for V_FMAMK instructions
These instructions use `src0`, `imm`, `src1` as operand. Fixes SWDEV-566579.
1 parent 7e7ea9c commit 4b01113

File tree

2 files changed

+39
-9
lines changed

2 files changed

+39
-9
lines changed

llvm/lib/Target/AMDGPU/Utils/AMDGPUBaseInfo.cpp

Lines changed: 18 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3439,17 +3439,31 @@ getVGPRLoweringOperandTables(const MCInstrDesc &Desc) {
34393439
AMDGPU::OpName::src0Y, AMDGPU::OpName::vsrc1Y, AMDGPU::OpName::vsrc2Y,
34403440
AMDGPU::OpName::vdstY};
34413441

3442+
// VOP2 MADMK instructions use src0, imm, src1 scheme.
3443+
static const AMDGPU::OpName VOP2MADMKOps[4] = {
3444+
AMDGPU::OpName::src0, AMDGPU::OpName::imm, AMDGPU::OpName::src1,
3445+
AMDGPU::OpName::vdst};
3446+
34423447
unsigned TSFlags = Desc.TSFlags;
34433448

34443449
if (TSFlags &
34453450
(SIInstrFlags::VOP1 | SIInstrFlags::VOP2 | SIInstrFlags::VOP3 |
34463451
SIInstrFlags::VOP3P | SIInstrFlags::VOPC | SIInstrFlags::DPP)) {
3452+
switch (Desc.getOpcode()) {
34473453
// LD_SCALE operands ignore MSB.
3448-
if (Desc.getOpcode() == AMDGPU::V_WMMA_LD_SCALE_PAIRED_B32 ||
3449-
Desc.getOpcode() == AMDGPU::V_WMMA_LD_SCALE_PAIRED_B32_gfx1250 ||
3450-
Desc.getOpcode() == AMDGPU::V_WMMA_LD_SCALE16_PAIRED_B64 ||
3451-
Desc.getOpcode() == AMDGPU::V_WMMA_LD_SCALE16_PAIRED_B64_gfx1250)
3454+
case AMDGPU::V_WMMA_LD_SCALE_PAIRED_B32:
3455+
case AMDGPU::V_WMMA_LD_SCALE_PAIRED_B32_gfx1250:
3456+
case AMDGPU::V_WMMA_LD_SCALE16_PAIRED_B64:
3457+
case AMDGPU::V_WMMA_LD_SCALE16_PAIRED_B64_gfx1250:
34523458
return {};
3459+
case AMDGPU::V_FMAMK_F32:
3460+
case AMDGPU::V_FMAMK_F32_gfx12:
3461+
case AMDGPU::V_FMAMK_F64:
3462+
case AMDGPU::V_FMAMK_F64_gfx1250:
3463+
return {VOP2MADMKOps, nullptr};
3464+
default:
3465+
break;
3466+
}
34533467
return {VOPOps, nullptr};
34543468
}
34553469

llvm/test/CodeGen/AMDGPU/vgpr-lowering-gfx1250.mir

Lines changed: 21 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -332,23 +332,39 @@ body: |
332332
; GCN-NEXT: v_fmaak_f32 v0 /*v256*/, v1, v2 /*v258*/, 0x1
333333
$vgpr256 = V_FMAAK_F32 undef $vgpr1, undef $vgpr258, 1, implicit $exec, implicit $mode
334334
335-
; GCN-NEXT: s_set_vgpr_msb 0x4445
335+
; GCN-NEXT: s_set_vgpr_msb 0x4451
336336
; GCN-NEXT: v_fmamk_f32 v0 /*v256*/, v1 /*v257*/, 0x1, v2 /*v258*/
337337
$vgpr256 = V_FMAMK_F32 undef $vgpr257, 1, undef $vgpr258, implicit $exec, implicit $mode
338338
339-
; GCN-NEXT: s_set_vgpr_msb 0x4505
339+
; GCN-NEXT: s_set_vgpr_msb 0x5111
340340
; GCN-NEXT: v_fmamk_f32 v0, v1 /*v257*/, 0x1, v2 /*v258*/
341341
$vgpr0 = V_FMAMK_F32 undef $vgpr257, 1, undef $vgpr258, implicit $exec, implicit $mode
342342
343-
; GCN-NEXT: s_set_vgpr_msb 0x541
343+
; GCN-NEXT: s_set_vgpr_msb 0x1141
344344
; GCN-NEXT: v_fmamk_f32 v0 /*v256*/, v1 /*v257*/, 0x1, v2
345345
$vgpr256 = V_FMAMK_F32 undef $vgpr257, 1, undef $vgpr2, implicit $exec, implicit $mode
346346
347-
; GCN-NEXT: s_set_vgpr_msb 0x4144
347+
; GCN-NEXT: s_set_vgpr_msb 0x4150
348348
; GCN-NEXT: v_fmamk_f32 v0 /*v256*/, v1, 0x1, v2 /*v258*/
349349
$vgpr256 = V_FMAMK_F32 undef $vgpr1, 1, undef $vgpr258, implicit $exec, implicit $mode
350350
351-
; ASM: NumVgprs: 259
351+
; GCN-NEXT: s_set_vgpr_msb 0x5051
352+
; GCN-NEXT: v_fmamk_f64 v[4:5] /*v[260:261]*/, v[100:101] /*v[356:357]*/, 0x1, v[2:3] /*v[258:259]*/
353+
$vgpr260_vgpr261 = V_FMAMK_F64 undef $vgpr356_vgpr357, 1, undef $vgpr258_vgpr259, implicit $exec, implicit $mode
354+
355+
; GCN-NEXT: s_set_vgpr_msb 0x5101
356+
; GCN-NEXT: v_fmamk_f64 v[0:1], v[100:101] /*v[356:357]*/, 0x1, v[2:3]
357+
$vgpr0_vgpr1 = V_FMAMK_F64 undef $vgpr356_vgpr357, 1, undef $vgpr2_vgpr3, implicit $exec, implicit $mode
358+
359+
; GCN-NEXT: s_set_vgpr_msb 0x110
360+
; GCN-NEXT: v_fmamk_f64 v[0:1], v[2:3], 0x1, v[100:101] /*v[356:357]*/
361+
$vgpr0_vgpr1 = V_FMAMK_F64 undef $vgpr2_vgpr3, 1, undef $vgpr356_vgpr357, implicit $exec, implicit $mode
362+
363+
; GCN-NEXT: s_set_vgpr_msb 0x1040
364+
; GCN-NEXT: v_fmamk_f64 v[0:1] /*v[256:257]*/, v[2:3], 0x1, v[4:5]
365+
$vgpr256_vgpr257 = V_FMAMK_F64 undef $vgpr2_vgpr3, 1, undef $vgpr4_vgpr5, implicit $exec, implicit $mode
366+
367+
; ASM: NumVgprs: 358
352368
353369
...
354370

0 commit comments

Comments
 (0)