Skip to content

Commit 4b0a756

Browse files
response to suggestions
Signed-off-by: Alexandre Eichenberger <[email protected]>
1 parent cc864c7 commit 4b0a756

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

mlir/include/mlir/Dialect/MemRef/IR/MemRefOps.td

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1351,9 +1351,12 @@ def MemRef_PrefetchOp : MemRef_Op<"prefetch"> {
13511351
instruction cache.
13521352
}];
13531353

1354-
// The memref argument is labeled with a MemWrite side effect to enforce a
1354+
// The memref argument is labeled with a side effect to enforce a
13551355
// relative ordering of the prefetch and other memory operations targeting
13561356
// that memory stream.
1357+
// We need it to be a write otherwise the operation would be trivially removed
1358+
// since it does not produce a value.
1359+
13571360
let arguments = (ins Arg<AnyMemRef, "prefetch address", [MemWrite]> :$memref,
13581361
Variadic<Index>:$indices,
13591362
BoolAttr:$isWrite,

0 commit comments

Comments
 (0)