addressing pr comments

Author: joaosaffran

llvm/include/llvm/BinaryFormat/DXContainer.h

@@ -579,13 +579,7 @@ struct RootParameter {
   };
   dxbc::ShaderVisibility ShaderVisibility;
 
-  RootParameter() {
-    ParameterType = dxbc::RootParameterType::Empty;
-    ShaderVisibility = dxbc::ShaderVisibility::Empty;
-  }
-
   void swapBytes() {
-    sys::swapByteOrder(ParameterType);
     sys::swapByteOrder(ShaderVisibility);
     switch (ParameterType) {
     case RootParameterType::Constants32Bit:
@@ -595,6 +589,7 @@ struct RootParameter {
       llvm_unreachable("invalid value for ParameterType");
       break;
     }
+    sys::swapByteOrder(ParameterType);
   }
 };
 

llvm/include/llvm/MC/DXContainerRootSignature.h

@@ -19,7 +19,7 @@ struct RootSignatureDesc {
 
   dxbc::RootSignatureHeader Header;
   SmallVector<dxbc::RootParameter> Parameters;
-  RootSignatureDesc() { Header = dxbc::RootSignatureHeader{2, 0}; }
+  RootSignatureDesc() : Header(dxbc::RootSignatureHeader{2, 0}) {}
 
   void write(raw_ostream &OS) const;
 };

llvm/include/llvm/Object/DXContainer.h

@@ -137,7 +137,9 @@ class RootSignature {
   uint32_t getRootParametersOffset() const { return RootParametersOffset; }
   uint32_t getNumStaticSamplers() const { return NumStaticSamplers; }
   uint32_t getStaticSamplersOffset() const { return StaticSamplersOffset; }
-  SmallVector<dxbc::RootParameter> getParameters() const { return Parameters; }
+  const SmallVector<dxbc::RootParameter> &getParameters() const {
+    return Parameters;
+  }
   uint32_t getFlags() const { return Flags; }
 };
 

llvm/lib/Object/DXContainer.cpp

@@ -319,10 +319,10 @@ Error DirectX::RootSignature::parse(StringRef Data) {
 
     switch (NewParam.ParameterType) {
 
-    case dxbc::RootParameterType::Constants32Bit: {
+    case dxbc::RootParameterType::Constants32Bit:
       if (Error Err = readStruct(Data, Begin + Offset, NewParam.Constants))
         return Err;
-    } break;
+      break;
     case dxbc::RootParameterType::Empty:
       // unreachable  because it was validated and assigned before this point.
       llvm_unreachable("Invalid value for RootParameterType");