Update C++ unittest according to David's suggestion

royitaqi · royitaqi · commit 4b9b7917e0a3 · 2025-04-21T15:56:47.000-07:00
diff --git a/lldb/unittests/Symbol/SymtabTest.cpp b/lldb/unittests/Symbol/SymtabTest.cpp
@@ -832,6 +832,6 @@ TEST_F(SymtabTest, TestSymbolTableCreatedOnDemand) {
   ASSERT_NE(symtab, nullptr);
 
   // And we should be able to get it again once it has been created.
-  symtab = symbol_file->GetSymtab(/*can_create=*/false);
-  ASSERT_NE(symtab, nullptr);
+  Symtab *cached_symtab = symbol_file->GetSymtab(/*can_create=*/false);
+  ASSERT_EQ(symtab, cached_symtab);
 }

Original file line number	Diff line number	Diff line change
`@@ -832,6 +832,6 @@ TEST_F(SymtabTest, TestSymbolTableCreatedOnDemand) {`
`832`	`832`	`ASSERT_NE(symtab, nullptr);`
`833`	`833`
`834`	`834`	`// And we should be able to get it again once it has been created.`
`835`		`- symtab = symbol_file->GetSymtab(/can_create=/false);`
`836`		`- ASSERT_NE(symtab, nullptr);`
	`835`	`+ Symtab cached_symtab = symbol_file->GetSymtab(/can_create=*/false);`
	`836`	`+ ASSERT_EQ(symtab, cached_symtab);`
`837`	`837`	`}`