Skip to content

Commit 4d1cb9b

Browse files
committed
[to squash] use casts directly in tests, use LIBC_INLINE and prefixes
Signed-off-by: Shreeyash Pandey <[email protected]>
1 parent 019fc9b commit 4d1cb9b

File tree

2 files changed

+7
-21
lines changed

2 files changed

+7
-21
lines changed

libc/src/__support/fixed_point/fx_bits.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -224,8 +224,8 @@ idiv(T x, T y) {
224224
return static_cast<XType>(result);
225225
}
226226

227-
inline long accum nrstep(long accum d, long accum x0) {
228-
auto v = x0 * (2 - (d * x0));
227+
LIBC_INLINE long accum nrstep(long accum d, long accum x0) {
228+
auto v = x0 * (2.lk - (d * x0));
229229
return v;
230230
}
231231

libc/test/src/stdfix/DivITest.h

Lines changed: 5 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -21,25 +21,11 @@ class DivITest : public LIBC_NAMESPACE::testing::Test {
2121
typedef XType (*DivIFunc)(int, int);
2222

2323
void testBasic(DivIFunc func) {
24-
auto c1 = func(2, 3);
25-
auto e1 = 0.666666;
26-
EXPECT_EQ(static_cast<XType>(c1), static_cast<XType>(e1));
27-
28-
c1 = func(3, 4);
29-
e1 = 0.75;
30-
EXPECT_EQ(static_cast<XType>(c1), static_cast<XType>(e1));
31-
32-
c1 = func(1043, 2764);
33-
e1 = 0.37735;
34-
EXPECT_EQ(static_cast<XType>(c1), static_cast<XType>(e1));
35-
36-
c1 = func(60000, 720293);
37-
e1 = 0.083299;
38-
EXPECT_EQ(static_cast<XType>(c1), static_cast<XType>(e1));
39-
40-
c1 = func(7, 3);
41-
e1 = 2.33333;
42-
EXPECT_EQ(static_cast<XType>(c1), static_cast<XType>(e1));
24+
EXPECT_EQ(static_cast<XType>(func(128,256)), static_cast<XType>(0.5));
25+
EXPECT_EQ(static_cast<XType>(func(2,3)), static_cast<XType>(0.666666));
26+
EXPECT_EQ(static_cast<XType>(func(3,4)), static_cast<XType>(0.75));
27+
EXPECT_EQ(static_cast<XType>(func(1043, 2764)), static_cast<XType>(0.37735));
28+
EXPECT_EQ(static_cast<XType>(func(60000, 720293)), static_cast<XType>(0.083299));
4329
}
4430
};
4531

0 commit comments

Comments
 (0)