Merge branch 'main' into users/mtrofin/one

Author: mtrofin

mlir/lib/Dialect/Linalg/Transforms/DecomposeGenericByUnfoldingPermutation.cpp

@@ -208,7 +208,7 @@ LogicalResult DecomposeProjectedPermutation::matchAndRewrite(
 
     // Does it require broadcast?
     if (!broadcastedDims.empty()) {
-      assert(broadcastedDims.size() && "should have non size broadcast");
+      assert(!broadcastedDims.empty() && "should have non size broadcast");
       Value emptyTensor = tensor::EmptyOp::create(rewriter, loc, outputShape,
                                                   inputRTType.getElementType());
 

mlir/lib/Dialect/OpenMP/IR/OpenMPDialect.cpp

@@ -3196,7 +3196,7 @@ void NewCliOp::getAsmResultNames(OpAsmSetValueNameFn setNameFn) {
               }
 
               SmallString<64> Name("canonloop");
-              for (std::string s : reverse(components)) {
+              for (const std::string &s : reverse(components)) {
                 Name += '_';
                 Name += s;
               }

mlir/lib/Dialect/Quant/Transforms/NormalizeQuantTypes.cpp

@@ -88,10 +88,10 @@ class NormalizedQuantTypesConverter : public TypeConverter {
           llvm::find_if(shape, [](int64_t dim) { return dim != 1; });
       auto scales = llvm::to_vector(llvm::map_range(
           subChannelType.getScales().getValues<APFloat>(),
-          [](APFloat scale) { return scale.convertToDouble(); }));
+          [](const APFloat &scale) { return scale.convertToDouble(); }));
       auto zeroPoints = llvm::to_vector(llvm::map_range(
           subChannelType.getZeroPoints().getValues<APInt>(),
-          [](APInt zeroPoint) { return zeroPoint.getSExtValue(); }));
+          [](const APInt &zeroPoint) { return zeroPoint.getSExtValue(); }));
       auto perAxisType = UniformQuantizedPerAxisType::get(
           subChannelType.getFlags(), subChannelType.getStorageType(),
           subChannelType.getExpressedType(), scales, zeroPoints,

mlir/lib/Dialect/Tosa/IR/TosaOps.cpp

@@ -512,20 +512,20 @@ void ReduceMinOp::print(OpAsmPrinter &parser) {
 // Tosa utilities.
 //===----------------------------------------------------------------------===//
 
-std::optional<int64_t> idivCheck(const int64_t lhs, const int64_t rhs) {
+static std::optional<int64_t> idivCheck(const int64_t lhs, const int64_t rhs) {
   if (lhs % rhs != 0)
     return std::nullopt;
   return lhs / rhs;
 }
 
-Type getStorageElementTypeOrSelf(Type type) {
+static Type getStorageElementTypeOrSelf(Type type) {
   auto srcType = getElementTypeOrSelf(type);
   if (auto quantType = llvm::dyn_cast<mlir::quant::QuantizedType>(srcType))
     srcType = quantType.getStorageType();
   return srcType;
 }
 
-Type getStorageElementTypeOrSelf(Value value) {
+static Type getStorageElementTypeOrSelf(Value value) {
   return getStorageElementTypeOrSelf(value.getType());
 }