[lldb] [disassembler] chore: enhance VariableAnnotator to return structured data: update both annotate and AnnotateStructured to use shared pointer tp module by value

Signed-off-by: Nikita B <[email protected]>

Author: n2h9

lldb/include/lldb/Core/Disassembler.h

@@ -599,14 +599,14 @@ class VariableAnnotator {
   /// Compute annotation strings for a single instruction and update `Live_`.
   /// Returns only the events that should be printed *at this instruction*.
   std::vector<std::string> annotate(Instruction &inst, Target &target,
-                                    const lldb::ModuleSP &module_sp);
+                                    lldb::ModuleSP module_sp);
 
   /// Compute structured annotation data for a single instruction and update
   /// `Live_`. Returns structured data for all variables relevant at this
   /// instruction.
-  std::vector<VariableAnnotation>
-  AnnotateStructured(Instruction &inst, Target &target,
-                     const lldb::ModuleSP &module_sp);
+  std::vector<VariableAnnotation> AnnotateStructured(Instruction &inst,
+                                                     Target &target,
+                                                     lldb::ModuleSP module_sp);
 };
 
 } // namespace lldb_private

lldb/source/Core/Disassembler.cpp

@@ -299,9 +299,9 @@ bool Disassembler::ElideMixedSourceAndDisassemblyLine(
 // The goal is to give users helpful live variable hints alongside the
 // disassembled instruction stream, similar to how debug information
 // enhances source-level debugging.
-std::vector<std::string>
-VariableAnnotator::annotate(Instruction &inst, Target &target,
-                            const lldb::ModuleSP &module_sp) {
+std::vector<std::string> VariableAnnotator::annotate(Instruction &inst,
+                                                     Target &target,
+                                                     lldb::ModuleSP module_sp) {
   auto structured_annotations = AnnotateStructured(inst, target, module_sp);
 
   std::vector<std::string> events;
@@ -325,7 +325,7 @@ VariableAnnotator::annotate(Instruction &inst, Target &target,
 
 std::vector<VariableAnnotation>
 VariableAnnotator::AnnotateStructured(Instruction &inst, Target &target,
-                                      const lldb::ModuleSP &module_sp) {
+                                      lldb::ModuleSP module_sp) {
   std::vector<VariableAnnotation> annotations;
 
   // If we lost module context, mark all live variables as undefined.