Addressed review comments

1. Delegated logic to Subtarget API from Tablegen.
2. Added a comment stating sm_101 is renamed to sm_110.

Author: rajatbajpai

llvm/lib/Target/NVPTX/NVPTXInstrInfo.td

@@ -111,31 +111,21 @@ class AnyPred<list<Predicate> Preds>
 // Checks PTX version and family-specific and architecture-specific SM versions.
 // For example, sm_100{f/a} and any future variants in the same family will match.
 class PTXWithFamilySMs<int PTXVersion, list<int> SMVersions> :
-  Predicate<"Subtarget->getPTXVersion() >= " # PTXVersion #
-            " && Subtarget->hasFamilySpecificFeatures()" #
-            " && (" #
-            !interleave(!foreach(sm, SMVersions,
-                        "(Subtarget->getSmFamilyVersion() == " # !div(sm, 10) #
-                        " && Subtarget->getSmVersion() >= " # sm # ")"),
-                        " || ") #
-            ")">;
+  Predicate<"Subtarget->hasPTXWithFamilySMs(" # PTXVersion # ", {" #
+            !interleave(SMVersions, ", ") # "})">;
 
 // Checks PTX version and architecture-specific SM versions.
 // For example, sm_100{a} will match.
 class PTXWithAccelSMs<int PTXVersion, list<int> SMVersions> :
-  Predicate<"Subtarget->getPTXVersion() >= " # PTXVersion #
-            " && Subtarget->hasArchAccelFeatures()" #
-            " && (" #
-            !interleave(!foreach(sm, SMVersions,
-                        "Subtarget->getSmVersion() == " # sm),
-                        " || ") #
-            ")">;
+  Predicate<"Subtarget->hasPTXWithAccelSMs(" # PTXVersion # ", {" #
+            !interleave(SMVersions, ", ") # "})">;
 
 // Helper predicate to call a subtarget method.
 class callSubtarget<string SubtargetMethod> : Predicate<"Subtarget->" # SubtargetMethod # "()">;
 
 // Composed predicate to check tcgen05.shift instructions support.
 def hasTcgen05ShiftSupport : AnyPred<[
+                                  // sm_101 renamed to sm_110 in PTX 9.0
                                   PTXWithAccelSMs<90, [100, 110, 103]>,
                                   PTXWithAccelSMs<88, [100, 101, 103]>,
                                   PTXWithAccelSMs<86, [100, 101]>

llvm/lib/Target/NVPTX/NVPTXSubtarget.cpp

@@ -77,25 +77,18 @@ bool NVPTXSubtarget::hasPTXWithFamilySMs(unsigned PTXVersion,
   if (!hasFamilySpecificFeatures() || getPTXVersion() < PTXVersion)
     return false;
 
-  for (unsigned SM : SMVersions) {
-    if (getSmFamilyVersion() == SM / 10 && getSmVersion() >= SM)
-      return true;
-  }
-
-  return false;
+  return llvm::any_of(SMVersions, [&](unsigned SM) {
+    return getSmFamilyVersion() == SM / 10 && getSmVersion() >= SM;
+  });
 }
 
 bool NVPTXSubtarget::hasPTXWithAccelSMs(unsigned PTXVersion,
                                         ArrayRef<unsigned> SMVersions) const {
   if (!hasArchAccelFeatures() || getPTXVersion() < PTXVersion)
     return false;
 
-  for (unsigned SM : SMVersions) {
-    if (getSmVersion() == SM)
-      return true;
-  }
-
-  return false;
+  return llvm::any_of(SMVersions,
+                      [&](unsigned SM) { return getSmVersion() == SM; });
 }
 
 bool NVPTXSubtarget::allowFP16Math() const {