Skip to content

Commit 4e706ad

Browse files
preamespreames
committed
[LoopPeel] Add test coverage for edge case for peel last
Add coverage for two cases: 1) Handling of the two transition edge case with equality conditions when last iteration is both first and second transition. 2) Need to handle inverted predicates
1 parent 9bda38f commit 4e706ad

File tree

1 file changed

+152
-1
lines changed

1 file changed

+152
-1
lines changed

‎llvm/test/Transforms/LoopUnroll/peel-last-iteration-with-variable-trip-count.ll‎

Lines changed: 152 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -171,6 +171,155 @@ exit:
171171
}
172172

173173

174+
define i32 @peel_last_with_trip_count_check_lcssa_phi_cmp_not_invar2(i32 %n) {
175+
; CHECK-LABEL: define i32 @peel_last_with_trip_count_check_lcssa_phi_cmp_not_invar2(
176+
; CHECK-SAME: i32 [[N:%.*]]) {
177+
; CHECK-NEXT: [[ENTRY:.*]]:
178+
; CHECK-NEXT: [[SUB:%.*]] = add i32 [[N]], -2
179+
; CHECK-NEXT: [[TMP0:%.*]] = add i32 [[N]], -1
180+
; CHECK-NEXT: [[TMP1:%.*]] = icmp ne i32 [[TMP0]], 0
181+
; CHECK-NEXT: br i1 [[TMP1]], label %[[ENTRY_SPLIT:.*]], label %[[EXIT_PEEL_BEGIN:.*]]
182+
; CHECK: [[ENTRY_SPLIT]]:
183+
; CHECK-NEXT: br label %[[LOOP:.*]]
184+
; CHECK: [[LOOP]]:
185+
; CHECK-NEXT: [[IV:%.*]] = phi i32 [ 0, %[[ENTRY_SPLIT]] ], [ [[IV_NEXT1:%.*]], %[[LOOP]] ]
186+
; CHECK-NEXT: [[C:%.*]] = icmp ne i32 [[IV]], [[SUB]]
187+
; CHECK-NEXT: [[SEL:%.*]] = select i1 [[C]], i32 1, i32 2
188+
; CHECK-NEXT: call void @foo(i32 [[SEL]])
189+
; CHECK-NEXT: [[IV_NEXT1]] = add nuw i32 [[IV]], 1
190+
; CHECK-NEXT: [[TMP2:%.*]] = sub i32 [[N]], 1
191+
; CHECK-NEXT: [[EC1:%.*]] = icmp ne i32 [[IV_NEXT1]], [[TMP2]]
192+
; CHECK-NEXT: br i1 [[EC1]], label %[[LOOP]], label %[[EXIT_PEEL_BEGIN_LOOPEXIT:.*]], !llvm.loop [[LOOP2:![0-9]+]]
193+
; CHECK: [[EXIT_PEEL_BEGIN_LOOPEXIT]]:
194+
; CHECK-NEXT: [[DOTPH:%.*]] = phi i32 [ [[IV_NEXT1]], %[[LOOP]] ]
195+
; CHECK-NEXT: br label %[[EXIT_PEEL_BEGIN]]
196+
; CHECK: [[EXIT_PEEL_BEGIN]]:
197+
; CHECK-NEXT: [[TMP3:%.*]] = phi i32 [ 0, %[[ENTRY]] ], [ [[DOTPH]], %[[EXIT_PEEL_BEGIN_LOOPEXIT]] ]
198+
; CHECK-NEXT: br label %[[LOOP_PEEL:.*]]
199+
; CHECK: [[LOOP_PEEL]]:
200+
; CHECK-NEXT: [[C_PEEL:%.*]] = icmp ne i32 [[TMP3]], [[SUB]]
201+
; CHECK-NEXT: [[SEL_LCSSA:%.*]] = select i1 [[C_PEEL]], i32 1, i32 2
202+
; CHECK-NEXT: call void @foo(i32 [[SEL_LCSSA]])
203+
; CHECK-NEXT: [[IV_NEXT:%.*]] = add i32 [[TMP3]], 1
204+
; CHECK-NEXT: [[EC:%.*]] = icmp ne i32 [[IV_NEXT]], [[N]]
205+
; CHECK-NEXT: br i1 [[EC]], label %[[EXIT_PEEL_NEXT:.*]], label %[[EXIT_PEEL_NEXT]]
206+
; CHECK: [[EXIT_PEEL_NEXT]]:
207+
; CHECK-NEXT: br label %[[LOOP_PEEL_NEXT:.*]]
208+
; CHECK: [[LOOP_PEEL_NEXT]]:
209+
; CHECK-NEXT: br label %[[EXIT:.*]]
210+
; CHECK: [[EXIT]]:
211+
; CHECK-NEXT: ret i32 [[SEL_LCSSA]]
212+
;
213+
entry:
214+
%sub = add i32 %n, -2
215+
br label %loop
216+
217+
loop:
218+
%iv = phi i32 [ 0, %entry ], [ %iv.next, %loop ]
219+
%c = icmp ne i32 %iv, %sub
220+
%sel = select i1 %c, i32 1, i32 2
221+
call void @foo(i32 %sel)
222+
%iv.next = add i32 %iv, 1
223+
%ec = icmp ne i32 %iv.next, %n
224+
br i1 %ec, label %loop, label %exit
225+
226+
exit:
227+
%sel.lcssa = phi i32 [ %sel, %loop ]
228+
ret i32 %sel.lcssa
229+
}
230+
231+
232+
233+
define i32 @peel_last_with_trip_count_check_lcssa_phi_cmp_not_invar3(i32 %n) {
234+
; CHECK-LABEL: define i32 @peel_last_with_trip_count_check_lcssa_phi_cmp_not_invar3(
235+
; CHECK-SAME: i32 [[N:%.*]]) {
236+
; CHECK-NEXT: [[ENTRY:.*]]:
237+
; CHECK-NEXT: [[SUB:%.*]] = add i32 [[N]], -1
238+
; CHECK-NEXT: [[TMP0:%.*]] = icmp ne i32 [[SUB]], 0
239+
; CHECK-NEXT: br i1 [[TMP0]], label %[[ENTRY_SPLIT:.*]], label %[[EXIT_PEEL_BEGIN:.*]]
240+
; CHECK: [[ENTRY_SPLIT]]:
241+
; CHECK-NEXT: br label %[[LOOP:.*]]
242+
; CHECK: [[LOOP]]:
243+
; CHECK-NEXT: [[IV:%.*]] = phi i32 [ 0, %[[ENTRY_SPLIT]] ], [ [[IV_NEXT:%.*]], %[[LOOP]] ]
244+
; CHECK-NEXT: call void @foo(i32 2)
245+
; CHECK-NEXT: [[IV_NEXT]] = add nuw i32 [[IV]], 1
246+
; CHECK-NEXT: [[TMP1:%.*]] = sub i32 [[N]], 1
247+
; CHECK-NEXT: [[EC:%.*]] = icmp ne i32 [[IV_NEXT]], [[TMP1]]
248+
; CHECK-NEXT: br i1 [[EC]], label %[[LOOP]], label %[[EXIT_PEEL_BEGIN_LOOPEXIT:.*]], !llvm.loop [[LOOP3:![0-9]+]]
249+
; CHECK: [[EXIT_PEEL_BEGIN_LOOPEXIT]]:
250+
; CHECK-NEXT: [[DOTPH:%.*]] = phi i32 [ [[IV_NEXT]], %[[LOOP]] ]
251+
; CHECK-NEXT: br label %[[EXIT_PEEL_BEGIN]]
252+
; CHECK: [[EXIT_PEEL_BEGIN]]:
253+
; CHECK-NEXT: [[TMP2:%.*]] = phi i32 [ 0, %[[ENTRY]] ], [ [[DOTPH]], %[[EXIT_PEEL_BEGIN_LOOPEXIT]] ]
254+
; CHECK-NEXT: br label %[[LOOP_PEEL:.*]]
255+
; CHECK: [[LOOP_PEEL]]:
256+
; CHECK-NEXT: [[C_PEEL:%.*]] = icmp eq i32 [[TMP2]], [[SUB]]
257+
; CHECK-NEXT: [[SEL_PEEL:%.*]] = select i1 [[C_PEEL]], i32 1, i32 2
258+
; CHECK-NEXT: call void @foo(i32 [[SEL_PEEL]])
259+
; CHECK-NEXT: [[IV_NEXT_PEEL:%.*]] = add i32 [[TMP2]], 1
260+
; CHECK-NEXT: [[EC_PEEL:%.*]] = icmp ne i32 [[IV_NEXT_PEEL]], [[N]]
261+
; CHECK-NEXT: br i1 [[EC_PEEL]], label %[[EXIT_PEEL_NEXT:.*]], label %[[EXIT_PEEL_NEXT]]
262+
; CHECK: [[EXIT_PEEL_NEXT]]:
263+
; CHECK-NEXT: br label %[[LOOP_PEEL_NEXT:.*]]
264+
; CHECK: [[LOOP_PEEL_NEXT]]:
265+
; CHECK-NEXT: br label %[[EXIT:.*]]
266+
; CHECK: [[EXIT]]:
267+
; CHECK-NEXT: ret i32 [[SEL_PEEL]]
268+
;
269+
entry:
270+
%sub = add i32 %n, -1
271+
br label %loop
272+
273+
loop:
274+
%iv = phi i32 [ 0, %entry ], [ %iv.next, %loop ]
275+
%c = icmp eq i32 %iv, %sub
276+
%sel = select i1 %c, i32 1, i32 2
277+
call void @foo(i32 %sel)
278+
%iv.next = add i32 %iv, 1
279+
%ec = icmp ne i32 %iv.next, %n
280+
br i1 %ec, label %loop, label %exit
281+
282+
exit:
283+
%sel.lcssa = phi i32 [ %sel, %loop ]
284+
ret i32 %sel.lcssa
285+
}
286+
287+
define i32 @peel_last_with_trip_count_check_lcssa_phi_cmp_not_invar4(i32 %n) {
288+
; CHECK-LABEL: define i32 @peel_last_with_trip_count_check_lcssa_phi_cmp_not_invar4(
289+
; CHECK-SAME: i32 [[N:%.*]]) {
290+
; CHECK-NEXT: [[ENTRY:.*]]:
291+
; CHECK-NEXT: [[SUB:%.*]] = add i32 [[N]], -1
292+
; CHECK-NEXT: br label %[[LOOP:.*]]
293+
; CHECK: [[LOOP]]:
294+
; CHECK-NEXT: [[IV:%.*]] = phi i32 [ 0, %[[ENTRY]] ], [ [[IV_NEXT:%.*]], %[[LOOP]] ]
295+
; CHECK-NEXT: [[C:%.*]] = icmp ne i32 [[IV]], [[SUB]]
296+
; CHECK-NEXT: [[SEL:%.*]] = select i1 [[C]], i32 1, i32 2
297+
; CHECK-NEXT: call void @foo(i32 [[SEL]])
298+
; CHECK-NEXT: [[IV_NEXT]] = add i32 [[IV]], 1
299+
; CHECK-NEXT: [[EC:%.*]] = icmp ne i32 [[IV_NEXT]], [[N]]
300+
; CHECK-NEXT: br i1 [[EC]], label %[[LOOP]], label %[[EXIT:.*]]
301+
; CHECK: [[EXIT]]:
302+
; CHECK-NEXT: [[SEL_LCSSA:%.*]] = phi i32 [ [[SEL]], %[[LOOP]] ]
303+
; CHECK-NEXT: ret i32 [[SEL_LCSSA]]
304+
;
305+
entry:
306+
%sub = add i32 %n, -1
307+
br label %loop
308+
309+
loop:
310+
%iv = phi i32 [ 0, %entry ], [ %iv.next, %loop ]
311+
%c = icmp ne i32 %iv, %sub
312+
%sel = select i1 %c, i32 1, i32 2
313+
call void @foo(i32 %sel)
314+
%iv.next = add i32 %iv, 1
315+
%ec = icmp ne i32 %iv.next, %n
316+
br i1 %ec, label %loop, label %exit
317+
318+
exit:
319+
%sel.lcssa = phi i32 [ %sel, %loop ]
320+
ret i32 %sel.lcssa
321+
}
322+
174323
define void @peel_last_with_trip_count_check_nested_loop(i32 %n) {
175324
; CHECK-LABEL: define void @peel_last_with_trip_count_check_nested_loop(
176325
; CHECK-SAME: i32 [[N:%.*]]) {
@@ -214,7 +363,7 @@ define void @peel_last_with_trip_count_check_nested_loop(i32 %n) {
214363
; CHECK-NEXT: [[IV_NEXT1]] = add nuw i32 [[IV1]], 1
215364
; CHECK-NEXT: [[TMP2:%.*]] = sub i32 [[N]], 1
216365
; CHECK-NEXT: [[EXITCOND_NOT1:%.*]] = icmp eq i32 [[IV_NEXT1]], [[TMP2]]
217-
; CHECK-NEXT: br i1 [[EXITCOND_NOT1]], label %[[OUTER_HEADER_LOOPEXIT_PEEL_BEGIN_LOOPEXIT]], label %[[INNER_HEADER]], !llvm.loop [[LOOP2:![0-9]+]]
366+
; CHECK-NEXT: br i1 [[EXITCOND_NOT1]], label %[[OUTER_HEADER_LOOPEXIT_PEEL_BEGIN_LOOPEXIT]], label %[[INNER_HEADER]], !llvm.loop [[LOOP4:![0-9]+]]
218367
;
219368
entry:
220369
%sub = add i32 %n, -1
@@ -242,4 +391,6 @@ inner.latch:
242391
; CHECK: [[LOOP0]] = distinct !{[[LOOP0]], [[META1:![0-9]+]]}
243392
; CHECK: [[META1]] = !{!"llvm.loop.peeled.count", i32 1}
244393
; CHECK: [[LOOP2]] = distinct !{[[LOOP2]], [[META1]]}
394+
; CHECK: [[LOOP3]] = distinct !{[[LOOP3]], [[META1]]}
395+
; CHECK: [[LOOP4]] = distinct !{[[LOOP4]], [[META1]]}
245396
;.

0 commit comments

Comments
 (0)