Skip to content

Commit 4e7ce57

Browse files
authored
[Offload][NFC] Offload wrapper cleanup/refactoring (#169411)
Addresses feedback from #147508 (review) : - Update access modifiers for SYCLWrapper members. - Update comments. - Update types.
1 parent ab5ae9a commit 4e7ce57

File tree

2 files changed

+167
-158
lines changed

2 files changed

+167
-158
lines changed

llvm/include/llvm/Frontend/Offloading/OffloadWrapper.h

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -56,18 +56,18 @@ LLVM_ABI llvm::Error wrapHIPBinary(llvm::Module &M, llvm::ArrayRef<char> Images,
5656
bool EmitSurfacesAndTextures = true);
5757

5858
struct SYCLJITOptions {
59-
// Target/compiler specific options that are suggested to use to "compile"
60-
// program at runtime.
59+
// Target/compiler specific options that are passed to the device compiler at
60+
// runtime.
6161
std::string CompileOptions;
62-
// Target/compiler specific options that are suggested to use to "link"
63-
// program at runtime.
62+
// Target/compiler specific options that are passed to the device linker at
63+
// runtime.
6464
std::string LinkOptions;
6565
};
6666

6767
/// Wraps OffloadBinaries in the given \p Buffers into the module \p M
6868
/// as global symbols and registers the images with the SYCL Runtime.
6969
/// \param Options Compiler and linker options to be encoded for the later
70-
/// use by a runtime for JIT compilation.
70+
/// use by a runtime for JIT compilation. Not used for AOT.
7171
LLVM_ABI llvm::Error
7272
wrapSYCLBinaries(llvm::Module &M, llvm::ArrayRef<char> Buffer,
7373
SYCLJITOptions Options = SYCLJITOptions());

0 commit comments

Comments
 (0)