Cleanup + FTM

Author: H-G-Hristov

libcxx/test/std/utilities/meta/meta.unary/meta.unary.prop/is_implicit_lifetime.pass.cpp

@@ -106,10 +106,8 @@ struct StructWithZeroSizedArray {
 };
 
 #ifdef TEST_COMPILER_CLANG
-// typedef int *align_value_int __attribute__((align_value(16)));
 using AlignValueInt = int* __attribute__((align_value(16)));
-// typedef float float4 __attribute__((ext_vector_type(4)));
-using Float4 = float __attribute__((ext_vector_type(4)));
+using Float4        = float __attribute__((ext_vector_type(4)));
 
 struct [[clang::enforce_read_only_placement]] EnforceReadOnlyPlacement {};
 struct [[clang::type_visibility("hidden")]] TypeVisibility {};
@@ -146,22 +144,6 @@ constexpr void test_is_implicit_lifetime() {
   test_is_implicit_lifetime<T[94], true>();
 }
 
-// #ifdef TEST_COMPILER_CLANG
-// // Test language extensions: attributes
-// template <typename T>
-// constexpr void test_is_implicit_lifetime_with_attributes() {
-//   test_is_implicit_lifetime<T [[clang::annotate_type("category2")]]*, true>();
-//   test_is_implicit_lifetime<T __attribute__((btf_type_tag("user")))*, true>();
-//   static_assert(__builtin_is_implicit_lifetime(int __attribute__((btf_type_tag("user"))) *));
-
-//   test_is_implicit_lifetime<T __attribute__((noderef))*, true>();
-
-//   test_is_implicit_lifetime<T* _Nonnull, true>();
-//   test_is_implicit_lifetime<T* _Null_unspecified, true>();
-//   test_is_implicit_lifetime<T* _Nullable, true>();
-// }
-// #endif // TEST_COMPILER_CLANG
-
 constexpr bool test() {
   // Standard fundamental C++ types
 
@@ -188,14 +170,6 @@ constexpr bool test() {
   test_is_implicit_lifetime<char16_t>();
   test_is_implicit_lifetime<char32_t>();
 
-  // test_is_implicit_lifetime<int, true>();
-  // test_is_implicit_lifetime<int&, false>();
-  // test_is_implicit_lifetime<int&&, false>();
-
-  // test_is_implicit_lifetime<int*, true>();
-  // test_is_implicit_lifetime<int[], true>();
-  // test_is_implicit_lifetime<int[0], true>();
-  // test_is_implicit_lifetime<int[94], true>();
   test_is_implicit_lifetime<short>();
   test_is_implicit_lifetime<short int>();
   test_is_implicit_lifetime<signed short>();
@@ -238,12 +212,6 @@ constexpr bool test() {
   test_is_implicit_lifetime<void (&)(), false>();
   test_is_implicit_lifetime<void (*)(), true>();
 
-  // test_is_implicit_lifetime<int UserDeclaredDestructor::*, true>();
-  // test_is_implicit_lifetime<int (UserDeclaredDestructor::*)(), true>();
-  // test_is_implicit_lifetime<int (UserDeclaredDestructor::*)() const, true>();
-  // test_is_implicit_lifetime<int (UserDeclaredDestructor::*)()&, true>();
-  // test_is_implicit_lifetime<int (UserDeclaredDestructor::*)()&&, true>();
-
   // Implicit-lifetime class types
 
   test_is_implicit_lifetime<EmptyStruct>();
@@ -301,10 +269,6 @@ constexpr bool test() {
   test_is_implicit_lifetime<_Complex double>();
   test_is_implicit_lifetime<_Complex long double>();
 
-  // test_is_implicit_lifetime<_Imaginary float>();
-  // test_is_implicit_lifetime<_Imaginary double>();
-  // test_is_implicit_lifetime<_Imaginary long double>();
-
   // Standard C23 types
 
 #ifdef TEST_COMPILER_CLANG
@@ -337,9 +301,6 @@ constexpr bool test() {
   test_is_implicit_lifetime<EnforceReadOnlyPlacement, true>();
   test_is_implicit_lifetime<TypeVisibility, true>();
 
-  // test_is_implicit_lifetime_with_attributes<int>();
-  // test_is_implicit_lifetime_with_attributes<float>();
-
   test_is_implicit_lifetime<int [[clang::annotate_type("category2")]]*, true>();
   test_is_implicit_lifetime<int __attribute__((btf_type_tag("user")))*, true>();
 

libcxx/test/std/utilities/meta/meta.unary/meta.unary.prop/is_implicit_lifetime.verify.cpp

@@ -25,13 +25,3 @@ static_assert(!std::is_implicit_lifetime<IncompleteStruct>::value);
 
 // expected-error@*:* {{atomic types are not supported in '__builtin_is_implicit_lifetime'}}
 static_assert(!std::is_implicit_lifetime<_Atomic int>::value);
-
-#if 0
-// FIXME: "variable length arrays in C++ are a Clang extension"
-void test(int n) {
-  int varArr[n];
-  using VarArrT = decltype(varArr);
-  // expected-error@*:* {{variable length arrays are not supported in '__builtin_is_implicit_lifetime'}}
-  static_assert(std::is_implicit_lifetime<VarArrT>::value);
-}
-#endif

libcxx/utils/generate_feature_test_macro_components.py

@@ -742,6 +742,14 @@ def add_version_header(tc):
             "values": {"c++14": 201402},
             "headers": ["type_traits"],
         },
+        {
+            "name": "__cpp_lib_is_implicit_lifetime",
+            "values": {"c++23": 202302},
+            "headers": ["type_traits"],
+            "test_suite_guard": "__has_builtin(__builtin_is_implicit_lifetime)",
+            "libcxx_guard": "__has_builtin(__builtin_is_implicit_lifetime)",
+            "unimplemented": True,
+        },
         {
             "name": "__cpp_lib_is_invocable",
             "values": {"c++17": 201703},