reduce opcodeToMask(Opcode) usage

HanKuanChen · HanKuanChen · commit 4f0008372a7b · 2025-02-25T06:40:14.000-08:00
diff --git a/llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp b/llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp
@@ -910,7 +910,8 @@ class InterchangeableBinOp {
         return trySet(MainOp_BIT);
       return false;
     }
-    SeenBefore |= opcodeToMask(Opcode);
+    MaskType opcodeMask = opcodeToMask(Opcode);
+    SeenBefore |= opcodeMask;
     ConstantInt *CI = isBinOpWithConstantInt(I).first;
     if (CI) {
       constexpr MaskType CanBeAll = Xor_BIT | Or_BIT | And_BIT | Sub_BIT |
@@ -937,7 +938,7 @@ class InterchangeableBinOp {
         break;
       }
     }
-    return trySet(opcodeToMask(Opcode));
+    return trySet(opcodeMask);
   }
   unsigned getOpcode() const {
     if (Mask & MainOp_BIT)

Original file line number	Diff line number	Diff line change
`@@ -910,7 +910,8 @@ class InterchangeableBinOp {`
`910`	`910`	`return trySet(MainOp_BIT);`
`911`	`911`	`return false;`
`912`	`912`	`}`
`913`		`- SeenBefore \|= opcodeToMask(Opcode);`
	`913`	`+ MaskType opcodeMask = opcodeToMask(Opcode);`
	`914`	`+ SeenBefore \|= opcodeMask;`
`914`	`915`	`ConstantInt *CI = isBinOpWithConstantInt(I).first;`
`915`	`916`	`if (CI) {`
`916`	`917`	`constexpr MaskType CanBeAll = Xor_BIT \| Or_BIT \| And_BIT \| Sub_BIT \|`
`@@ -937,7 +938,7 @@ class InterchangeableBinOp {`
`937`	`938`	`break;`
`938`	`939`	`}`
`939`	`940`	`}`
`940`		`- return trySet(opcodeToMask(Opcode));`
	`941`	`+ return trySet(opcodeMask);`
`941`	`942`	`}`
`942`	`943`	`unsigned getOpcode() const {`
`943`	`944`	`if (Mask & MainOp_BIT)`