Skip to content

Commit 4fa53ef

Browse files
committed
Rebase and a little refactor
1 parent 91eb3be commit 4fa53ef

File tree

2 files changed

+9
-14
lines changed

2 files changed

+9
-14
lines changed

libcxx/test/benchmarks/GenerateInput.h

Lines changed: 9 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -108,29 +108,25 @@ std::vector<IntT> getRandomIntegerInputs(std::size_t N) {
108108
return inputs;
109109
}
110110

111-
inline std::vector<std::string> getDuplicateStringInputs(std::size_t N) {
112-
std::vector<std::string> inputs(N, getRandomString(1024));
113-
return inputs;
114-
}
115-
116-
inline std::vector<std::string> getRandomStringInputs(std::size_t N) {
111+
inline std::vector<std::string> getRandomStringInputsWithLength(std::size_t N, std::size_t len) { // N-by-len
117112
std::vector<std::string> inputs;
118113
inputs.reserve(N);
119114
for (std::size_t i = 0; i < N; ++i)
120-
inputs.push_back(getRandomString(1024));
115+
inputs.push_back(getRandomString(len));
121116
return inputs;
122117
}
123118

124-
inline std::vector<std::string> getRandomStringInputsWithLength(std::size_t N, std::size_t len) { // N-by-len
125-
std::vector<std::string> inputs;
126-
inputs.reserve(N);
127-
for (std::size_t i = 0; i < N; ++i)
128-
inputs.push_back(getRandomString(len));
119+
inline std::vector<std::string> getDuplicateStringInputs(std::size_t N) {
120+
std::vector<std::string> inputs(N, getRandomString(1024));
129121
return inputs;
130122
}
131123

124+
inline std::vector<std::string> getRandomStringInputs(std::size_t N) {
125+
return getRandomStringInputsWithLength(N, 1024);
126+
}
127+
132128
template <class IntT>
133-
inline std::vector<std::vector<IntT>> getRandomIntegerInputsWithLength(std::size_t N, std::size_t len) { // N-by-len
129+
std::vector<std::vector<IntT>> getRandomIntegerInputsWithLength(std::size_t N, std::size_t len) { // N-by-len
134130
std::vector<std::vector<IntT>> inputs;
135131
inputs.reserve(N);
136132
for (std::size_t i = 0; i < N; ++i)

libcxx/test/benchmarks/vector_operations.bench.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818
#include <vector>
1919

2020
#include "benchmark/benchmark.h"
21-
2221
#include "ContainerBenchmarks.h"
2322
#include "GenerateInput.h"
2423

0 commit comments

Comments
 (0)