Skip to content

Commit 4fc323e

Browse files
committed
Add TODO to performExtractVectorEltCombine()
1 parent 1943ddc commit 4fc323e

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

llvm/lib/Target/AMDGPU/SIISelLowering.cpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14680,6 +14680,8 @@ SITargetLowering::performExtractVectorEltCombine(SDNode *N,
1468014680
// depending on the shift operand. See e.g. performSraCombine().
1468114681
// This combine ensures that the optimisation is compatible with v2i32
1468214682
// legalised AND.
14683+
// TODO: Consider if additional improvements can be made by generalising to
14684+
// other constants and vector types.
1468314685
if (VecVT == MVT::v2i32 && Vec->getOpcode() == ISD::AND &&
1468414686
Vec->getOperand(1)->getOpcode() == ISD::BUILD_VECTOR) {
1468514687
SDValue BV = Vec->getOperand(1);

0 commit comments

Comments
 (0)