Refactor

Author: winner245

libcxx/test/std/containers/sequences/vector/common.h

@@ -50,8 +50,7 @@ struct throwing_t {
 
 template <class T>
 struct throwing_allocator {
-  using value_type      = T;
-  using is_always_equal = std::false_type;
+  using value_type = T;
 
   bool throw_on_copy_ = false;
 

libcxx/test/std/containers/sequences/vector/vector.cons/exceptions.pass.cpp

@@ -44,8 +44,8 @@ int main(int, char**) {
   }
   check_new_delete_called();
 
-  try {                                         // Throw in vector(size_type, const allocator_type&) from allocator
-    throwing_allocator<int> alloc(false, true); // throw on copy only
+  try { // Throw in vector(size_type, const allocator_type&) from allocator
+    throwing_allocator<int> alloc(/*throw_on_ctor = */ false, /*throw_on_copy = */ true);
     AllocVec get_alloc(0, alloc);
   } catch (int) {
   }
@@ -106,7 +106,7 @@ int main(int, char**) {
 
   try { // Throw in vector(InputIterator, InputIterator, const allocator_type&) from allocator
     int a[] = {1, 2};
-    throwing_allocator<int> alloc(false, true); // throw on copy only
+    throwing_allocator<int> alloc(/*throw_on_ctor = */ false, /*throw_on_copy = */ true);
     AllocVec vec(cpp17_input_iterator<int*>(a), cpp17_input_iterator<int*>(a + 2), alloc);
   } catch (int) {
     // FIXME: never called.
@@ -115,7 +115,7 @@ int main(int, char**) {
 
   try { // Throw in vector(InputIterator, InputIterator, const allocator_type&) from allocator
     int a[] = {1, 2};
-    throwing_allocator<int> alloc(false, true); // throw on copy only
+    throwing_allocator<int> alloc(/*throw_on_ctor = */ false, /*throw_on_copy = */ true);
     AllocVec vec(forward_iterator<int*>(a), forward_iterator<int*>(a + 2), alloc);
   } catch (int) {
     // FIXME: never called.