Skip to content

Commit 503b7c6

Browse files
committed
Address reviewer feedback for #embed test
Remove defined(__has_embed) check and use since-cxx23 verify prefix to align with C++ DR test conventions.
1 parent aa99069 commit 503b7c6

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

clang/test/Preprocessor/cxx_oper_comma.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@
33
// RUN: %clang_cc1 -E -pedantic-errors %s -verify -std=c++14
44
// RUN: %clang_cc1 -E -pedantic-errors %s -verify -std=c++17
55
// RUN: %clang_cc1 -E -pedantic-errors %s -verify -std=c++20
6-
// RUN: %clang_cc1 -E -pedantic-errors %s -verify=expected,embed -std=c++23 -Wno-c23-extensions
7-
// RUN: %clang_cc1 -E -pedantic-errors %s -verify=expected,embed -std=c++2c -Wno-c23-extensions
6+
// RUN: %clang_cc1 -E -pedantic-errors %s -verify=expected,since-cxx23 -std=c++23 -Wno-c23-extensions
7+
// RUN: %clang_cc1 -E -pedantic-errors %s -verify=expected,since-cxx23 -std=c++2c -Wno-c23-extensions
88

99
// Test 1: Top-level comma
1010
// expected-error@+1 {{expected end of line in preprocessor expression}}
@@ -39,7 +39,7 @@
3939
#endif
4040

4141
// Test 7: Comma in #embed limit parameter (C++23+)
42-
#if defined(__has_embed) && __cplusplus >= 202302L
43-
// embed-error@+1 {{expected ')'}}
42+
#if __cplusplus >= 202302L
43+
// since-cxx23-error@+1 {{expected ')'}}
4444
#embed "jk.txt" limit(1, 2)
4545
#endif

0 commit comments

Comments
 (0)