Skip to content

Commit 504b7b5

Browse files
committed
fix review comments
1 parent 64d7d69 commit 504b7b5

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

clang-tools-extra/clang-tidy/misc/RedundantExpressionCheck.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -808,7 +808,7 @@ static bool isSameRawIdentifierToken(const Token &T1, const Token &T2,
808808
StringRef(SM.getCharacterData(T2.getLocation()), T2.getLength());
809809
}
810810

811-
bool isTokAtEndOfExpr(SourceRange ExprSR, Token T, const SourceManager &SM) {
811+
static bool isTokAtEndOfExpr(SourceRange ExprSR, Token T, const SourceManager &SM) {
812812
return SM.getExpansionLoc(ExprSR.getEnd()) == T.getLocation();
813813
}
814814

clang-tools-extra/clang-tidy/modernize/UseNullptrCheck.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,6 @@ using namespace llvm;
2121
namespace clang::tidy::modernize {
2222
namespace {
2323

24-
const char CastSequence[] = "sequence";
25-
2624
AST_MATCHER(Type, sugaredNullptrType) {
2725
const Type *DesugaredType = Node.getUnqualifiedDesugaredType();
2826
if (const auto *BT = dyn_cast<BuiltinType>(DesugaredType))
@@ -32,6 +30,8 @@ AST_MATCHER(Type, sugaredNullptrType) {
3230

3331
} // namespace
3432

33+
static const char CastSequence[] = "sequence";
34+
3535
/// Create a matcher that finds implicit casts as well as the head of a
3636
/// sequence of zero or more nested explicit casts that have an implicit cast
3737
/// to null within.

0 commit comments

Comments
 (0)