Skip to content

Commit 5059b2f

Browse files
committed
changes based on comments
1 parent 2deba83 commit 5059b2f

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

llvm/lib/CodeGen/GlobalISel/CombinerHelper.cpp

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2097,8 +2097,8 @@ bool CombinerHelper::matchCommuteShift(MachineInstr &MI,
20972097
bool CombinerHelper::matchLshrOfTruncOfLshr(MachineInstr &MI,
20982098
LshrOfTruncOfLshr &MatchInfo,
20992099
MachineInstr &ShiftMI) const {
2100-
unsigned ShiftOpcode = MI.getOpcode();
2101-
assert(ShiftOpcode == TargetOpcode::G_LSHR);
2100+
//unsigned ShiftOpcode = MI.getOpcode();
2101+
assert(MI.getOpcode() == TargetOpcode::G_LSHR && "Expected a G_LSHR");
21022102

21032103
Register N0 = MI.getOperand(1).getReg();
21042104
Register N1 = MI.getOperand(2).getReg();
@@ -2138,8 +2138,8 @@ bool CombinerHelper::matchLshrOfTruncOfLshr(MachineInstr &MI,
21382138

21392139
void CombinerHelper::applyLshrOfTruncOfLshr(
21402140
MachineInstr &MI, LshrOfTruncOfLshr &MatchInfo) const {
2141-
unsigned ShiftOpcode = MI.getOpcode();
2142-
assert(ShiftOpcode == TargetOpcode::G_LSHR);
2141+
//unsigned ShiftOpcode = MI.getOpcode();
2142+
assert(MI.getOpcode() == TargetOpcode::G_LSHR && "Expected a G_LSHR");
21432143

21442144
Register Dst = MI.getOperand(0).getReg();
21452145
auto ShiftAmt =
@@ -2150,7 +2150,7 @@ void CombinerHelper::applyLshrOfTruncOfLshr(
21502150
APInt MaskVal =
21512151
APInt::getLowBitsSet(MatchInfo.InnerShiftTy.getScalarSizeInBits(),
21522152
MatchInfo.MaskVal.getZExtValue());
2153-
auto Mask = Builder.buildConstant(MatchInfo.ShiftAmtTy, MaskVal);
2153+
auto Mask = Builder.buildConstant(MatchInfo.InnerShiftTy, MaskVal);
21542154
auto And = Builder.buildAnd(MatchInfo.InnerShiftTy, Shift, Mask);
21552155
Builder.buildTrunc(Dst, And);
21562156
} else

0 commit comments

Comments
 (0)