Fix build issues

mleleszi · mleleszi · commit 506b66b9ed10 · 2025-11-04T15:29:31.000Z
diff --git a/libc/src/stdio/asprintf.cpp b/libc/src/stdio/asprintf.cpp
@@ -31,7 +31,7 @@ LLVM_LIBC_FUNCTION(int, asprintf,
     libc_errno = printf_core::internal_error_to_errno(ret_val.error());
     return -1;
   }
-  if (ret_val.value() > cpp::numeric_limits<int>::max()) {
+  if (ret_val.value() > static_cast<size_t>(cpp::numeric_limits<int>::max())) {
     libc_errno =
         printf_core::internal_error_to_errno(-printf_core::OVERFLOW_ERROR);
     return -1;
diff --git a/libc/src/stdio/baremetal/printf.cpp b/libc/src/stdio/baremetal/printf.cpp
@@ -57,7 +57,7 @@ LLVM_LIBC_FUNCTION(int, printf, (const char *__restrict format, ...)) {
     return -1;
   }
 
-  if (retval.value() > cpp::numeric_limits<int>::max()) {
+  if (retval.value() > static_cast<size_t>(cpp::numeric_limits<int>::max())) {
     libc_errno =
         printf_core::internal_error_to_errno(-printf_core::OVERFLOW_ERROR);
     return -1;
diff --git a/libc/src/stdio/baremetal/vprintf.cpp b/libc/src/stdio/baremetal/vprintf.cpp
@@ -55,7 +55,7 @@ LLVM_LIBC_FUNCTION(int, vprintf,
     return -1;
   }
 
-  if (retval.value() > cpp::numeric_limits<int>::max()) {
+  if (retval.value() > static_cast<size_t>(cpp::numeric_limits<int>::max())) {
     libc_errno =
         printf_core::internal_error_to_errno(-printf_core::OVERFLOW_ERROR);
     return -1;
diff --git a/libc/src/stdio/generic/fprintf.cpp b/libc/src/stdio/generic/fprintf.cpp
@@ -35,7 +35,7 @@ LLVM_LIBC_FUNCTION(int, fprintf,
     libc_errno = printf_core::internal_error_to_errno(ret_val.error());
     return -1;
   }
-  if (ret_val.value() > cpp::numeric_limits<int>::max()) {
+  if (ret_val.value() > static_cast<size_t>(cpp::numeric_limits<int>::max())) {
     libc_errno =
         printf_core::internal_error_to_errno(-printf_core::OVERFLOW_ERROR);
     return -1;
diff --git a/libc/src/stdio/generic/printf.cpp b/libc/src/stdio/generic/printf.cpp
@@ -40,7 +40,7 @@ LLVM_LIBC_FUNCTION(int, printf, (const char *__restrict format, ...)) {
     libc_errno = printf_core::internal_error_to_errno(ret_val.error());
     return -1;
   }
-  if (ret_val.value() > cpp::numeric_limits<int>::max()) {
+  if (ret_val.value() > static_cast<size_t>(cpp::numeric_limits<int>::max())) {
     libc_errno =
         printf_core::internal_error_to_errno(-printf_core::OVERFLOW_ERROR);
     return -1;
diff --git a/libc/src/stdio/generic/vfprintf.cpp b/libc/src/stdio/generic/vfprintf.cpp
@@ -32,7 +32,7 @@ LLVM_LIBC_FUNCTION(int, vfprintf,
     libc_errno = printf_core::internal_error_to_errno(ret_val.error());
     return -1;
   }
-  if (ret_val.value() > cpp::numeric_limits<int>::max()) {
+  if (ret_val.value() > static_cast<size_t>(cpp::numeric_limits<int>::max())) {
     libc_errno =
         printf_core::internal_error_to_errno(-printf_core::OVERFLOW_ERROR);
     return -1;
diff --git a/libc/src/stdio/generic/vprintf.cpp b/libc/src/stdio/generic/vprintf.cpp
@@ -38,7 +38,7 @@ LLVM_LIBC_FUNCTION(int, vprintf,
     libc_errno = printf_core::internal_error_to_errno(ret_val.error());
     return -1;
   }
-  if (ret_val.value() > cpp::numeric_limits<int>::max()) {
+  if (ret_val.value() > static_cast<size_t>(cpp::numeric_limits<int>::max())) {
     libc_errno =
         printf_core::internal_error_to_errno(-printf_core::OVERFLOW_ERROR);
     return -1;
diff --git a/libc/src/stdio/snprintf.cpp b/libc/src/stdio/snprintf.cpp
@@ -44,7 +44,7 @@ LLVM_LIBC_FUNCTION(int, snprintf,
   if (buffsz > 0) // if the buffsz is 0 the buffer may be a null pointer.
     wb.buff[wb.buff_cur] = '\0';
 
-  if (ret_val.value() > cpp::numeric_limits<int>::max()) {
+  if (ret_val.value() > static_cast<size_t>(cpp::numeric_limits<int>::max())) {
     libc_errno =
         printf_core::internal_error_to_errno(-printf_core::OVERFLOW_ERROR);
     return -1;
diff --git a/libc/src/stdio/sprintf.cpp b/libc/src/stdio/sprintf.cpp
@@ -43,7 +43,7 @@ LLVM_LIBC_FUNCTION(int, sprintf,
   }
   wb.buff[wb.buff_cur] = '\0';
 
-  if (ret_val.value() > cpp::numeric_limits<int>::max()) {
+  if (ret_val.value() > static_cast<size_t>(cpp::numeric_limits<int>::max())) {
     libc_errno =
         printf_core::internal_error_to_errno(-printf_core::OVERFLOW_ERROR);
     return -1;
diff --git a/libc/src/stdio/vasprintf.cpp b/libc/src/stdio/vasprintf.cpp
@@ -27,7 +27,7 @@ LLVM_LIBC_FUNCTION(int, vasprintf,
     libc_errno = printf_core::internal_error_to_errno(ret_val.error());
     return -1;
   }
-  if (ret_val.value() > cpp::numeric_limits<int>::max()) {
+  if (ret_val.value() > static_cast<size_t>(cpp::numeric_limits<int>::max())) {
     libc_errno =
         printf_core::internal_error_to_errno(-printf_core::OVERFLOW_ERROR);
     return -1;
diff --git a/libc/src/stdio/vsnprintf.cpp b/libc/src/stdio/vsnprintf.cpp
@@ -41,7 +41,7 @@ LLVM_LIBC_FUNCTION(int, vsnprintf,
   if (buffsz > 0) // if the buffsz is 0 the buffer may be a null pointer.
     wb.buff[wb.buff_cur] = '\0';
 
-  if (ret_val.value() > cpp::numeric_limits<int>::max()) {
+  if (ret_val.value() > static_cast<size_t>(cpp::numeric_limits<int>::max())) {
     libc_errno =
         printf_core::internal_error_to_errno(-printf_core::OVERFLOW_ERROR);
     return -1;
diff --git a/libc/src/stdio/vsprintf.cpp b/libc/src/stdio/vsprintf.cpp
@@ -40,7 +40,7 @@ LLVM_LIBC_FUNCTION(int, vsprintf,
   }
   wb.buff[wb.buff_cur] = '\0';
 
-  if (ret_val.value() > cpp::numeric_limits<int>::max()) {
+  if (ret_val.value() > static_cast<size_t>(cpp::numeric_limits<int>::max())) {
     libc_errno =
         printf_core::internal_error_to_errno(-printf_core::OVERFLOW_ERROR);
     return -1;
diff --git a/libc/src/stdlib/strfromd.cpp b/libc/src/stdlib/strfromd.cpp
@@ -39,7 +39,8 @@ LLVM_LIBC_FUNCTION(int, strfromd,
   if (n > 0)
     wb.buff[wb.buff_cur] = '\0';
 
-  if (writer.get_chars_written() > cpp::numeric_limits<int>::max()) {
+  if (writer.get_chars_written() >
+      static_cast<size_t>(cpp::numeric_limits<int>::max())) {
     libc_errno =
         printf_core::internal_error_to_errno(-printf_core::OVERFLOW_ERROR);
     return -1;
diff --git a/libc/src/stdlib/strfroml.cpp b/libc/src/stdlib/strfroml.cpp
@@ -44,7 +44,8 @@ LLVM_LIBC_FUNCTION(int, strfroml,
   if (n > 0)
     wb.buff[wb.buff_cur] = '\0';
 
-  if (writer.get_chars_written() > cpp::numeric_limits<int>::max()) {
+  if (writer.get_chars_written() >
+      static_cast<size_t>(cpp::numeric_limits<int>::max())) {
     libc_errno =
         printf_core::internal_error_to_errno(-printf_core::OVERFLOW_ERROR);
     return -1;
diff --git a/libc/test/src/stdio/snprintf_test.cpp b/libc/test/src/stdio/snprintf_test.cpp
@@ -72,5 +72,5 @@ TEST(LlvmLibcSNPrintfTest, CharsWrittenOverflow) {
   int int_max = LIBC_NAMESPACE::cpp::numeric_limits<int>::max();
   int written = LIBC_NAMESPACE::snprintf(buff, 0, "%*stest", int_max, "");
   EXPECT_LT(written, 0);
-  ASSERT_ERRNO_EQ(EOVERFLOW);
+  ASSERT_ERRNO_FAILURE();
 }

Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,7 @@ LLVM_LIBC_FUNCTION(int, asprintf,`
`31`	`31`	`libc_errno = printf_core::internal_error_to_errno(ret_val.error());`
`32`	`32`	`return -1;`
`33`	`33`	`}`
`34`		`- if (ret_val.value() > cpp::numeric_limits<int>::max()) {`
	`34`	`+ if (ret_val.value() > static_cast<size_t>(cpp::numeric_limits<int>::max())) {`
`35`	`35`	`libc_errno =`
`36`	`36`	`printf_core::internal_error_to_errno(-printf_core::OVERFLOW_ERROR);`
`37`	`37`	`return -1;`
Original file line number	Diff line number	Diff line change
`@@ -57,7 +57,7 @@ LLVM_LIBC_FUNCTION(int, printf, (const char *__restrict format, ...)) {`
`57`	`57`	`return -1;`
`58`	`58`	`}`
`59`	`59`
`60`		`- if (retval.value() > cpp::numeric_limits<int>::max()) {`
	`60`	`+ if (retval.value() > static_cast<size_t>(cpp::numeric_limits<int>::max())) {`
`61`	`61`	`libc_errno =`
`62`	`62`	`printf_core::internal_error_to_errno(-printf_core::OVERFLOW_ERROR);`
`63`	`63`	`return -1;`
Original file line number	Diff line number	Diff line change
`@@ -55,7 +55,7 @@ LLVM_LIBC_FUNCTION(int, vprintf,`
`55`	`55`	`return -1;`
`56`	`56`	`}`
`57`	`57`
`58`		`- if (retval.value() > cpp::numeric_limits<int>::max()) {`
	`58`	`+ if (retval.value() > static_cast<size_t>(cpp::numeric_limits<int>::max())) {`
`59`	`59`	`libc_errno =`
`60`	`60`	`printf_core::internal_error_to_errno(-printf_core::OVERFLOW_ERROR);`
`61`	`61`	`return -1;`
Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,7 @@ LLVM_LIBC_FUNCTION(int, fprintf,`
`35`	`35`	`libc_errno = printf_core::internal_error_to_errno(ret_val.error());`
`36`	`36`	`return -1;`
`37`	`37`	`}`
`38`		`- if (ret_val.value() > cpp::numeric_limits<int>::max()) {`
	`38`	`+ if (ret_val.value() > static_cast<size_t>(cpp::numeric_limits<int>::max())) {`
`39`	`39`	`libc_errno =`
`40`	`40`	`printf_core::internal_error_to_errno(-printf_core::OVERFLOW_ERROR);`
`41`	`41`	`return -1;`
Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,7 @@ LLVM_LIBC_FUNCTION(int, printf, (const char *__restrict format, ...)) {`
`40`	`40`	`libc_errno = printf_core::internal_error_to_errno(ret_val.error());`
`41`	`41`	`return -1;`
`42`	`42`	`}`
`43`		`- if (ret_val.value() > cpp::numeric_limits<int>::max()) {`
	`43`	`+ if (ret_val.value() > static_cast<size_t>(cpp::numeric_limits<int>::max())) {`
`44`	`44`	`libc_errno =`
`45`	`45`	`printf_core::internal_error_to_errno(-printf_core::OVERFLOW_ERROR);`
`46`	`46`	`return -1;`
Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,7 @@ LLVM_LIBC_FUNCTION(int, vfprintf,`
`32`	`32`	`libc_errno = printf_core::internal_error_to_errno(ret_val.error());`
`33`	`33`	`return -1;`
`34`	`34`	`}`
`35`		`- if (ret_val.value() > cpp::numeric_limits<int>::max()) {`
	`35`	`+ if (ret_val.value() > static_cast<size_t>(cpp::numeric_limits<int>::max())) {`
`36`	`36`	`libc_errno =`
`37`	`37`	`printf_core::internal_error_to_errno(-printf_core::OVERFLOW_ERROR);`
`38`	`38`	`return -1;`
Original file line number	Diff line number	Diff line change
`@@ -38,7 +38,7 @@ LLVM_LIBC_FUNCTION(int, vprintf,`
`38`	`38`	`libc_errno = printf_core::internal_error_to_errno(ret_val.error());`
`39`	`39`	`return -1;`
`40`	`40`	`}`
`41`		`- if (ret_val.value() > cpp::numeric_limits<int>::max()) {`
	`41`	`+ if (ret_val.value() > static_cast<size_t>(cpp::numeric_limits<int>::max())) {`
`42`	`42`	`libc_errno =`
`43`	`43`	`printf_core::internal_error_to_errno(-printf_core::OVERFLOW_ERROR);`
`44`	`44`	`return -1;`
Original file line number	Diff line number	Diff line change
`@@ -43,7 +43,7 @@ LLVM_LIBC_FUNCTION(int, sprintf,`
`43`	`43`	`}`
`44`	`44`	`wb.buff[wb.buff_cur] = '\0';`
`45`	`45`
`46`		`- if (ret_val.value() > cpp::numeric_limits<int>::max()) {`
	`46`	`+ if (ret_val.value() > static_cast<size_t>(cpp::numeric_limits<int>::max())) {`
`47`	`47`	`libc_errno =`
`48`	`48`	`printf_core::internal_error_to_errno(-printf_core::OVERFLOW_ERROR);`
`49`	`49`	`return -1;`
Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,7 @@ LLVM_LIBC_FUNCTION(int, vasprintf,`
`27`	`27`	`libc_errno = printf_core::internal_error_to_errno(ret_val.error());`
`28`	`28`	`return -1;`
`29`	`29`	`}`
`30`		`- if (ret_val.value() > cpp::numeric_limits<int>::max()) {`
	`30`	`+ if (ret_val.value() > static_cast<size_t>(cpp::numeric_limits<int>::max())) {`
`31`	`31`	`libc_errno =`
`32`	`32`	`printf_core::internal_error_to_errno(-printf_core::OVERFLOW_ERROR);`
`33`	`33`	`return -1;`