Skip to content

Commit 508f9a0

Browse files
authored
[Offload] Skip event tests on AMDGPU (#148632)
Add `OffloadDeviceTest::getPlatformBackend()` and use it to skip event tests which currently fail on AMDGPU due to: ``` OL_ERRC_UNIMPLEMENTED: synchronize event not implemented ```
1 parent 0ad2574 commit 508f9a0

File tree

2 files changed

+17
-0
lines changed

2 files changed

+17
-0
lines changed

offload/unittests/OffloadAPI/common/Fixtures.hpp

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,18 @@ struct OffloadDeviceTest
7373
GTEST_SKIP() << "No available devices.";
7474
}
7575

76+
ol_platform_backend_t getPlatformBackend() const {
77+
ol_platform_handle_t Platform = nullptr;
78+
if (olGetDeviceInfo(Device, OL_DEVICE_INFO_PLATFORM,
79+
sizeof(ol_platform_handle_t), &Platform))
80+
return OL_PLATFORM_BACKEND_UNKNOWN;
81+
ol_platform_backend_t Backend;
82+
if (olGetPlatformInfo(Platform, OL_PLATFORM_INFO_BACKEND,
83+
sizeof(ol_platform_backend_t), &Backend))
84+
return OL_PLATFORM_BACKEND_UNKNOWN;
85+
return Backend;
86+
}
87+
7688
ol_device_handle_t Device = nullptr;
7789
};
7890

@@ -159,6 +171,8 @@ struct OffloadQueueTest : OffloadDeviceTest {
159171
struct OffloadEventTest : OffloadQueueTest {
160172
void SetUp() override {
161173
RETURN_ON_FATAL_FAILURE(OffloadQueueTest::SetUp());
174+
if (getPlatformBackend() == OL_PLATFORM_BACKEND_AMDGPU)
175+
GTEST_SKIP() << "AMDGPU synchronize event not implemented";
162176

163177
// Get an event from a memcpy. We can still use it in olGetEventInfo etc
164178
// after it has been waited on.

offload/unittests/OffloadAPI/event/olWaitEvent.cpp

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,9 @@ using olWaitEventTest = OffloadQueueTest;
1414
OFFLOAD_TESTS_INSTANTIATE_DEVICE_FIXTURE(olWaitEventTest);
1515

1616
TEST_P(olWaitEventTest, Success) {
17+
if (getPlatformBackend() == OL_PLATFORM_BACKEND_AMDGPU)
18+
GTEST_SKIP() << "AMDGPU synchronize event not implemented";
19+
1720
uint32_t Src = 42;
1821
void *DstPtr;
1922

0 commit comments

Comments
 (0)