Add h-vetinari's additional info

Meinersbur · Meinersbur · commit 50acc4fffcb1 · 2024-11-14T17:21:44.000+01:00
diff --git a/flang-rt/lib/flang_rt/CMakeLists.txt b/flang-rt/lib/flang_rt/CMakeLists.txt
@@ -170,10 +170,11 @@ else()
   #    flang_rt.dynamic, this results in a recursive dependency when invoking
   #    the linker.
   #
-  #  * The externally-visible functions must either by annotated with
+  #  * The externally-visible functions must either be annotated with
   #    __declspec(dllexport), or listed in a exports file. A possible workaround
   #    is CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS which would also export the internal
-  #    C++ symbols.
+  #    C++ symbols and still requires global data symbols by be annotated
+  #    manually.
   #
   #add_win_flangrt_library(SHARED dynamic     MultiThreadedDLL)
   #add_win_flangrt_library(SHARED dynamic_dbg MultiThreadedDebugDLL)

Original file line number	Diff line number	Diff line change
`@@ -170,10 +170,11 @@ else()`
`170`	`170`	`# flang_rt.dynamic, this results in a recursive dependency when invoking`
`171`	`171`	`# the linker.`
`172`	`172`	`#`
`173`		`- # * The externally-visible functions must either by annotated with`
	`173`	`+ # * The externally-visible functions must either be annotated with`
`174`	`174`	`# __declspec(dllexport), or listed in a exports file. A possible workaround`
`175`	`175`	`# is CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS which would also export the internal`
`176`		`- # C++ symbols.`
	`176`	`+ # C++ symbols and still requires global data symbols by be annotated`
	`177`	`+ # manually.`
`177`	`178`	`#`
`178`	`179`	`#add_win_flangrt_library(SHARED dynamic MultiThreadedDLL)`
`179`	`180`	`#add_win_flangrt_library(SHARED dynamic_dbg MultiThreadedDebugDLL)`