Follow LLVM naming conventions for function parameters

Author: jiang1997

clang/lib/CIR/CodeGen/CIRGenCXXABI.cpp

@@ -77,19 +77,19 @@ void CIRGenCXXABI::setCXXABIThisValue(CIRGenFunction &cgf,
   cgf.cxxabiThisValue = thisPtr;
 }
 
-CharUnits CIRGenCXXABI::getArrayCookieSize(const CXXNewExpr *E) {
-  if (!requiresArrayCookie(E))
+CharUnits CIRGenCXXABI::getArrayCookieSize(const CXXNewExpr *e) {
+  if (!requiresArrayCookie(e))
     return CharUnits::Zero();
 
-  cgm.errorNYI(E->getSourceRange(), "CIRGenCXXABI::getArrayCookieSize");
+  cgm.errorNYI(e->getSourceRange(), "CIRGenCXXABI::getArrayCookieSize");
   return CharUnits::Zero();
 }
 
-bool CIRGenCXXABI::requiresArrayCookie(const CXXNewExpr *E) {
+bool CIRGenCXXABI::requiresArrayCookie(const CXXNewExpr *e) {
   // If the class's usual deallocation function takes two arguments,
   // it needs a cookie.
-  if (E->doesUsualArrayDeleteWantSize())
+  if (e->doesUsualArrayDeleteWantSize())
     return true;
 
-  return E->getAllocatedType().isDestructedType();
+  return e->getAllocatedType().isDestructedType();
 }

clang/lib/CIR/CodeGen/CIRGenCXXABI.h

@@ -28,7 +28,7 @@ class CIRGenCXXABI {
   CIRGenModule &cgm;
   std::unique_ptr<clang::MangleContext> mangleContext;
 
-  virtual bool requiresArrayCookie(const CXXNewExpr *E);
+  virtual bool requiresArrayCookie(const CXXNewExpr *e);
 
 public:
   // TODO(cir): make this protected when target-specific CIRGenCXXABIs are
@@ -255,7 +255,7 @@ class CIRGenCXXABI {
   ///   - calls to \::operator new(size_t, void*) never need a cookie
   ///
   /// \param E - the new-expression being allocated.
-  virtual CharUnits getArrayCookieSize(const CXXNewExpr *E);
+  virtual CharUnits getArrayCookieSize(const CXXNewExpr *e);
 };
 
 /// Creates and Itanium-family ABI

clang/lib/CIR/CodeGen/CIRGenExprCXX.cpp

@@ -339,7 +339,7 @@ static mlir::Value emitCXXNewAllocSize(CIRGenFunction &cgf, const CXXNewExpr *e,
     unsigned numElementsWidth = count.getBitWidth();
 
     // The equivalent code in CodeGen/CGExprCXX.cpp handles these cases as
-    // overflow, but they should never happen. The size argument is implicitly
+    // overflow, but that should never happen. The size argument is implicitly
     // cast to a size_t, so it can never be negative and numElementsWidth will
     // always equal sizeWidth.
     assert(!count.isNegative() && "Expected non-negative array size");
@@ -350,7 +350,7 @@ static mlir::Value emitCXXNewAllocSize(CIRGenFunction &cgf, const CXXNewExpr *e,
     llvm::APInt adjustedCount = count.zextOrTrunc(sizeWidth);
 
     // Scale numElements by that.  This might overflow, but we don't
-    // care because it only overflows if allocationSize does, too, and
+    // care because it only overflows if allocationSize does too, and
     // if that overflows then we shouldn't use this.
     // This emits a constant that may not be used, but we can't tell here
     // whether it will be needed or not.