Address Feedback Nr.2

Author: alx32

lld/MachO/Config.h

@@ -143,6 +143,7 @@ struct Configuration {
   bool timeTraceEnabled = false;
   bool dataConst = false;
   bool dedupStrings = true;
+  bool dedupSymbolStrings = true;
   bool deadStripDuplicates = false;
   bool omitDebugInfo = false;
   bool warnDylibInstallName = false;
@@ -256,8 +257,6 @@ struct Configuration {
   llvm::MachO::PlatformType platform() const {
     return platformInfo.target.Platform;
   }
-
-  bool deduplicateSymbolStrings = true;
 };
 
 extern std::unique_ptr<Configuration> config;

lld/MachO/Driver.cpp

@@ -1806,8 +1806,7 @@ bool link(ArrayRef<const char *> argsArr, llvm::raw_ostream &stdoutOS,
   config->keepICFStabs = args.hasArg(OPT_keep_icf_stabs);
   config->dedupStrings =
       args.hasFlag(OPT_deduplicate_strings, OPT_no_deduplicate_strings, true);
-  config->deduplicateSymbolStrings =
-      !args.hasArg(OPT_no_deduplicate_symbol_strings);
+  config->dedupSymbolStrings = !args.hasArg(OPT_no_deduplicate_symbol_strings);
   config->deadStripDuplicates = args.hasArg(OPT_dead_strip_duplicates);
   config->warnDylibInstallName = args.hasFlag(
       OPT_warn_dylib_install_name, OPT_no_warn_dylib_install_name, false);

lld/MachO/SyntheticSections.cpp

@@ -1541,8 +1541,7 @@ StringTableSection::StringTableSection()
 
 uint32_t StringTableSection::addString(StringRef str) {
   uint32_t strx = size;
-  if (config->deduplicateSymbolStrings) {
-    // Deduplicate strings
+  if (config->dedupSymbolStrings) {
     llvm::CachedHashStringRef hashedStr(str);
     auto [it, inserted] = stringMap.try_emplace(hashedStr, strx);
     if (!inserted)