Skip to content

Commit 51d1802

Browse files
committed
[clang] Update #embed directive completion placeholders and add test
1 parent 90f7d02 commit 51d1802

File tree

2 files changed

+9
-4
lines changed

2 files changed

+9
-4
lines changed

clang/lib/Sema/SemaCodeComplete.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10209,19 +10209,19 @@ void SemaCodeCompletion::CodeCompletePreprocessorDirective(bool InConditional) {
1020910209
Results.AddResult(Builder.TakeString());
1021010210

1021110211
if (getLangOpts().C23) {
10212-
// #embed "header"
10212+
// #embed "file"
1021310213
Builder.AddTypedTextChunk("embed");
1021410214
Builder.AddChunk(CodeCompletionString::CK_HorizontalSpace);
1021510215
Builder.AddTextChunk("\"");
10216-
Builder.AddPlaceholderChunk("header");
10216+
Builder.AddPlaceholderChunk("file");
1021710217
Builder.AddTextChunk("\"");
1021810218
Results.AddResult(Builder.TakeString());
1021910219

10220-
// #embed <header>
10220+
// #embed <file>
1022110221
Builder.AddTypedTextChunk("embed");
1022210222
Builder.AddChunk(CodeCompletionString::CK_HorizontalSpace);
1022310223
Builder.AddTextChunk("<");
10224-
Builder.AddPlaceholderChunk("header");
10224+
Builder.AddPlaceholderChunk("file");
1022510225
Builder.AddTextChunk(">");
1022610226
Results.AddResult(Builder.TakeString());
1022710227
}

clang/test/Index/complete-preprocessor.m

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -80,3 +80,8 @@
8080
// RUN: env CINDEXTEST_EDITING=1 CINDEXTEST_COMPLETION_CACHING=1 c-index-test -code-completion-at=%s:9:8 %s | FileCheck -check-prefix=CHECK-CC3 %s
8181
// RUN: env CINDEXTEST_EDITING=1 CINDEXTEST_COMPLETION_CACHING=1 c-index-test -code-completion-at=%s:11:5 %s | FileCheck -check-prefix=CHECK-CC4 %s
8282
// RUN: env CINDEXTEST_EDITING=1 CINDEXTEST_COMPLETION_CACHING=1 c-index-test -code-completion-at=%s:14:5 %s | FileCheck -check-prefix=CHECK-CC5 %s
83+
84+
// Test #embed completion in C23 mode
85+
// RUN: c-index-test -code-completion-at=%s:4:2 %s -std=c23 | FileCheck -check-prefix=CHECK-EMBED %s
86+
// CHECK-EMBED: NotImplemented:{TypedText embed}{HorizontalSpace }{Text "}{Placeholder file}{Text "} (40)
87+
// CHECK-EMBED: NotImplemented:{TypedText embed}{HorizontalSpace }{Text <}{Placeholder file}{Text >} (40)

0 commit comments

Comments
 (0)