format

Author: Joao Saffran

llvm/lib/Target/DirectX/DXILPostOptimizationValidation.cpp

@@ -19,7 +19,6 @@
 #include "llvm/IR/Module.h"
 #include "llvm/InitializePasses.h"
 #include "llvm/Support/DXILABI.h"
-#include "llvm/Support/ErrorHandling.h"
 
 #define DEBUG_TYPE "dxil-post-optimization-validation"
 

llvm/test/CodeGen/DirectX/rootsignature-validation-deny-no-binding.ll

@@ -1,5 +1,5 @@
-; RUN: opt -S -passes='dxil-post-optimization-validation' %s 2>&1 
-; expected-no-diagnostics
+; RUN: opt -S -passes='dxil-post-optimization-validation' %s 
+; This is a valid case where no resource is being used
 target triple = "dxil-pc-shadermodel6.6-pixel"
 
 define void @CSMain() #0 {
@@ -11,5 +11,7 @@ attributes #0 = { noinline nounwind "exp-shader"="cs" "hlsl.numthreads"="1,2,1"
 !dx.rootsignatures = !{!0}
 
 !0 = !{ptr @CSMain, !1, i32 2}
-!1 = !{!2}
-!2 = !{ !"RootFlags", i32 294 } ; 32 = deny_pixel/hull/vertex/amplification_shader_root_access
+!1 = !{!2, !3, !4}
+!2 = !{!"RootConstants", i32 0, i32 2, i32 0, i32 4}
+!3 = !{ !"RootFlags", i32 294 } ; 32 = deny_pixel/hull/vertex/amplification_shader_root_access
+!4 = !{ !"RootSRV", i32 0, i32 1, i32 0, i32 0 }

llvm/test/CodeGen/DirectX/rootsignature-validation-deny-shader.ll

@@ -1,5 +1,5 @@
-; RUN: opt -S -passes='dxil-post-optimization-validation' %s 2>&1 
-; expected-no-diagnostics
+; RUN: opt -S -passes='dxil-post-optimization-validation' %s 
+; Valid scenario where shader stage is not blocked from accessing root bindings
 target triple = "dxil-pc-shadermodel6.6-geometry"
 
 define void @CSMain() #0 {
@@ -11,5 +11,6 @@ attributes #0 = { noinline nounwind "exp-shader"="cs" "hlsl.numthreads"="1,2,1"
 !dx.rootsignatures = !{!0}
 
 !0 = !{ptr @CSMain, !1, i32 2}
-!1 = !{!2}
+!1 = !{!2, !3}
 !2 = !{ !"RootFlags", i32 294 } ; 32 = deny_pixel/hull/vertex/amplification_shader_root_access
+!3 = !{ !"RootCBV", i32 0, i32 1, i32 0, i32 0 }

llvm/test/CodeGen/DirectX/rootsignature-validation-fail-deny-multiple-shader.ll

@@ -1,5 +1,4 @@
 ; RUN: not opt -S -passes='dxil-post-optimization-validation' %s 2>&1 | FileCheck %s
-
 ; CHECK: error: Shader has root bindings but root signature uses a DENY flag to disallow root binding access to the shader stage.
 target triple = "dxil-pc-shadermodel6.6-pixel"