DetermineCopyInOut() is now called at ProcedureRef instantiation

Author: eugeneepshteyn

flang/include/flang/Evaluate/call.h

@@ -249,9 +249,6 @@ class ProcedureRef {
       bool hasAlternateReturns = false)
       : proc_{std::move(p)}, arguments_{std::move(a)},
         hasAlternateReturns_{hasAlternateReturns} {
-    // Gathers necessary information to determine the need for copy-in and
-    // copy-out
-    DetermineCopyInOut();
   }
   ~ProcedureRef();
   static void Deleter(ProcedureRef *);
@@ -289,9 +286,9 @@ class ProcedureRef {
   bool operator==(const ProcedureRef &) const;
   llvm::raw_ostream &AsFortran(llvm::raw_ostream &) const;
 
-protected:
   void DetermineCopyInOut();
 
+protected:
   ProcedureDesignator proc_;
   ActualArguments arguments_;
   Chevrons chevrons_;

flang/lib/Semantics/expression.cpp

@@ -3455,6 +3455,7 @@ void ExpressionAnalyzer::Analyze(const parser::CallStmt &callStmt) {
                 HasAlternateReturns(callee->arguments)},
             ProcedureRef::Deleter);
         DEREF(callStmt.typedCall.get()).set_chevrons(std::move(*chevrons));
+        DEREF(callStmt.typedCall.get()).DetermineCopyInOut();
         return;
       }
     }