use ConfinedAttr to constrain values

Author: Hsiangkai

mlir/include/mlir/Dialect/GPU/IR/GPUOps.td

@@ -1368,7 +1368,9 @@ def GPU_ShuffleOp : GPU_Op<
 
 def GPU_RotateOp : GPU_Op<
     "rotate", [Pure, AllTypesMatch<["value", "rotateResult"]>]>,
-    Arguments<(ins AnyIntegerOrFloatOr1DVector:$value, I32Attr:$offset, I32Attr:$width)>,
+    Arguments<(ins AnyIntegerOrFloatOr1DVector:$value,
+                   ConfinedAttr<I32Attr, [IntMinValue<0>]>:$offset,
+                   ConfinedAttr<I32Attr, [IntPowerOf2]>:$width)>,
     Results<(outs AnyIntegerOrFloatOr1DVector:$rotateResult, I1:$valid)> {
   let summary = "Rotate values within a subgroup.";
   let description = [{

mlir/lib/Dialect/GPU/IR/GPUDialect.cpp

@@ -1399,9 +1399,6 @@ LogicalResult RotateOp::verify() {
   uint32_t offset = getOffset();
   uint32_t width = getWidth();
 
-  if (!llvm::isPowerOf2_32(width))
-    return emitOpError() << "width must be a power of two";
-
   if (offset >= width) {
     return emitOpError() << "offset must be in the range [0, " << width << ")";
   }

mlir/test/Dialect/GPU/invalid.mlir

@@ -505,7 +505,7 @@ func.func @rotate_unsupported_type_vec(%arg0 : vector<[4]xf32>) {
 // -----
 
 func.func @rotate_unsupported_width(%arg0 : f32) {
-  // expected-error@+1 {{op width must be a power of two}}
+  // expected-error@+1 {{'gpu.rotate' op attribute 'width' failed to satisfy constraint: 32-bit signless integer attribute whose value is a power of two > 0}}
   %rotate, %valid = "gpu.rotate"(%arg0) { offset = 4 : i32, width = 15 : i32 } : (f32) -> (f32, i1)
   return
 }
@@ -521,7 +521,7 @@ func.func @rotate_unsupported_offset(%arg0 : f32) {
 // -----
 
 func.func @rotate_unsupported_offset_minus(%arg0 : f32) {
-  // expected-error@+1 {{op offset must be in the range [0, 16)}}
+  // expected-error@+1 {{'gpu.rotate' op attribute 'offset' failed to satisfy constraint: 32-bit signless integer attribute whose minimum value is 0}}
   %rotate, %valid = "gpu.rotate"(%arg0) { offset = -1 : i32, width = 16 : i32 } : (f32) -> (f32, i1)
   return
 }