Rename API for clarity

Author: AaronBallman

clang/include/clang/AST/DeclCXX.h

@@ -2858,7 +2858,7 @@ class CXXDestructorDecl : public CXXMethodDecl {
   /// Will this destructor ever be called when considering which deallocation
   /// function is associated with the destructor? Can optionally be passed an
   /// 'operator delete' function declaration to test against specifically.
-  bool isDestructorCalled(const FunctionDecl *OpDel = nullptr) const;
+  bool isCalledByDelete(const FunctionDecl *OpDel = nullptr) const;
 
   CXXDestructorDecl *getCanonicalDecl() override {
     return cast<CXXDestructorDecl>(FunctionDecl::getCanonicalDecl());

clang/lib/AST/DeclCXX.cpp

@@ -2969,7 +2969,7 @@ void CXXDestructorDecl::setOperatorDelete(FunctionDecl *OD, Expr *ThisArg) {
   }
 }
 
-bool CXXDestructorDecl::isDestructorCalled(const FunctionDecl *OpDel) const {
+bool CXXDestructorDecl::isCalledByDelete(const FunctionDecl *OpDel) const {
   // C++20 [expr.delete]p6: If the value of the operand of the delete-
   // expression is not a null pointer value and the selected deallocation
   // function (see below) is not a destroying operator delete, the delete-

clang/lib/Sema/SemaExceptionSpec.cpp

@@ -1213,7 +1213,7 @@ CanThrowResult Sema::canThrow(const Stmt *S) {
       const FunctionDecl *OperatorDelete = DE->getOperatorDelete();
       if (const auto *RD = DTy->getAsCXXRecordDecl()) {
         if (const CXXDestructorDecl *DD = RD->getDestructor();
-            DD && DD->isDestructorCalled(OperatorDelete))
+            DD && DD->isCalledByDelete(OperatorDelete))
           CT = canCalleeThrow(*this, DE, DD);
       }
 

clang/lib/Sema/SemaExprCXX.cpp

@@ -3794,7 +3794,7 @@ Sema::ActOnCXXDelete(SourceLocation StartLoc, bool UseGlobal,
 
       if (!PointeeRD->hasIrrelevantDestructor()) {
         if (CXXDestructorDecl *Dtor = LookupDestructor(PointeeRD)) {
-          if (Dtor->isDestructorCalled(OperatorDelete)) {
+          if (Dtor->isCalledByDelete(OperatorDelete)) {
             MarkFunctionReferenced(StartLoc,
                                    const_cast<CXXDestructorDecl *>(Dtor));
             if (DiagnoseUseOfDecl(Dtor, StartLoc))
@@ -3836,7 +3836,7 @@ Sema::ActOnCXXDelete(SourceLocation StartLoc, bool UseGlobal,
     bool IsVirtualDelete = false;
     if (PointeeRD) {
       if (CXXDestructorDecl *Dtor = LookupDestructor(PointeeRD)) {
-        if (Dtor->isDestructorCalled(OperatorDelete))
+        if (Dtor->isCalledByDelete(OperatorDelete))
           CheckDestructorAccess(Ex.get()->getExprLoc(), Dtor,
                                 PDiag(diag::err_access_dtor) << PointeeElem);
         IsVirtualDelete = Dtor->isVirtual();