[clang][bytecode][NFC] Avoid creating pointers in CopyArray op

tbaederr · tbaederr · commit 5379022529e4 · 2025-10-12T07:24:49.000+02:00
diff --git a/clang/lib/AST/ByteCode/Interp.h b/clang/lib/AST/ByteCode/Interp.h
@@ -3183,9 +3183,8 @@ inline bool CopyArray(InterpState &S, CodePtr OpPC, uint32_t SrcIndex,
     if (!CheckLoad(S, OpPC, SP))
       return false;
 
-    const Pointer &DP = DestPtr.atIndex(DestIndex + I);
-    DP.deref<T>() = SP.deref<T>();
-    DP.initialize();
+    DestPtr.elem<T>(DestIndex + I) = SrcPtr.elem<T>(SrcIndex + I);
+    DestPtr.initializeElement(DestIndex + I);
   }
   return true;
 }

Original file line number	Diff line number	Diff line change
`@@ -3183,9 +3183,8 @@ inline bool CopyArray(InterpState &S, CodePtr OpPC, uint32_t SrcIndex,`
`3183`	`3183`	`if (!CheckLoad(S, OpPC, SP))`
`3184`	`3184`	`return false;`
`3185`	`3185`
`3186`		`- const Pointer &DP = DestPtr.atIndex(DestIndex + I);`
`3187`		`- DP.deref<T>() = SP.deref<T>();`
`3188`		`- DP.initialize();`
	`3186`	`+ DestPtr.elem<T>(DestIndex + I) = SrcPtr.elem<T>(SrcIndex + I);`
	`3187`	`+ DestPtr.initializeElement(DestIndex + I);`
`3189`	`3188`	`}`
`3190`	`3189`	`return true;`
`3191`	`3190`	`}`