Skip to content

Commit 53a51f9

Browse files
committed
Fix typo & use target_link_options now that we're on cmake 3.20
1 parent 6f0768f commit 53a51f9

File tree

2 files changed

+10
-10
lines changed

2 files changed

+10
-10
lines changed

lldb/tools/lldb-dap/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ add_lldb_library(lldbDAP
7777
)
7878

7979
target_include_directories(lldbDAP
80-
PUBLIC ${CMAKE_CURRENT_SOURCE_DIR} ${CMAKE_CURRENT_BINARY_DIR_DIR})
80+
PUBLIC ${CMAKE_CURRENT_SOURCE_DIR} ${CMAKE_CURRENT_BINARY_DIR})
8181

8282
if(LLDB_DAP_WELCOME_MESSAGE)
8383
target_compile_definitions(lldbDAP

lldb/tools/lldb-dap/tool/CMakeLists.txt

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,19 @@
1-
if(APPLE)
2-
configure_file(
3-
${CMAKE_CURRENT_SOURCE_DIR}/lldb-dap-Info.plist.in
4-
${CMAKE_CURRENT_BINARY_DIR}/lldb-dap-Info.plist
5-
)
6-
# Inline info plist in binary (use target_link_options for this as soon as CMake 3.13 is available)
7-
set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} -Wl,-sectcreate,__TEXT,__info_plist,${CMAKE_CURRENT_BINARY_DIR}/lldb-dap-Info.plist")
8-
endif()
9-
101
add_lldb_tool(lldb-dap
112
lldb-dap.cpp
123

134
LINK_LIBS
145
lldbDAP
156
)
167

8+
if(APPLE)
9+
configure_file(
10+
${CMAKE_CURRENT_SOURCE_DIR}/lldb-dap-Info.plist.in
11+
${CMAKE_CURRENT_BINARY_DIR}/lldb-dap-Info.plist
12+
)
13+
target_link_options(lldb-dap
14+
PRIVATE LINKER:-sectcreate,__TEXT,__info_plist,${CMAKE_CURRENT_BINARY_DIR}/lldb-dap-Info.plist)
15+
endif()
16+
1717
if(LLDB_BUILD_FRAMEWORK)
1818
# In the build-tree, we know the exact path to the framework directory.
1919
# The installed framework can be in different locations.

0 commit comments

Comments
 (0)