Skip to content

Commit 547a6aa

Browse files
committed
Revert "Add a TODO with potential CheckAny optimization"
This reverts commit 2d49938c2a8be4ed10f2392d01cc0665c24a776a. Implemented suggestion results in increased table sizes on average. The number of elements in scopes is too small for the suggestion to be beneficial.
1 parent bc4b239 commit 547a6aa

File tree

1 file changed

+0
-5
lines changed

1 file changed

+0
-5
lines changed

llvm/utils/TableGen/DecoderEmitter.cpp

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1663,11 +1663,6 @@ void DecoderTableEmitter::emitCheckAnyNode(const CheckAnyNode *N,
16631663
return;
16641664
}
16651665

1666-
// TODO: Emit single OPC_Scope and check at runtime where the scope ends.
1667-
// Not that it would save much space: OPC_Scope means we've resolved
1668-
// a conflict, and there aren't many of them. AMDGPU is an exception,
1669-
// it has ~3.5K OPC_Scope opcodes, but most, if not all scopes contain
1670-
// only two children.
16711666
for (const DecoderTreeNode *Child : drop_end(N->children())) {
16721667
emitOpcode("OPC_Scope");
16731668
emitULEB128(computeNodeSize(Child));

0 commit comments

Comments
 (0)