Skip to content

Commit 5486f2b

Browse files
committed
[AMDGPU][MC]FMA-mix instructions should not be supported in GFX908, GFX90a, and GFX940
FMA-mix instructions, including v_fma_mix_f32, v_fma_mixhi_f16, and v_fma_mixlo_f16 should not be supported in GFX908, GFX90a, and GFX940.
1 parent 97b0d20 commit 5486f2b

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

llvm/lib/Target/AMDGPU/AMDGPU.td

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1348,8 +1348,7 @@ def FeatureISAVersion9_Generic : FeatureSet<
13481348

13491349
def FeatureISAVersion9_0_MI_Common : FeatureSet<
13501350
!listconcat(FeatureISAVersion9_0_Common.Features,
1351-
[FeatureFmaMixInsts,
1352-
FeatureDLInsts,
1351+
[FeatureDLInsts,
13531352
FeatureDot1Insts,
13541353
FeatureDot2Insts,
13551354
FeatureDot3Insts,
@@ -1426,7 +1425,6 @@ def FeatureISAVersion9_4_Common : FeatureSet<
14261425
[FeatureGFX9,
14271426
FeatureGFX90AInsts,
14281427
FeatureGFX940Insts,
1429-
FeatureFmaMixInsts,
14301428
FeatureLDSBankCount32,
14311429
FeatureDLInsts,
14321430
FeatureFmacF64Inst,

llvm/test/MC/AMDGPU/fma-mix.s

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,9 @@
11
// RUN: llvm-mc -triple=amdgcn -mcpu=gfx904 -show-encoding %s | FileCheck -check-prefix=GFX9-FMAMIX %s
22
// RUN: llvm-mc -triple=amdgcn -mcpu=gfx906 -show-encoding %s | FileCheck -check-prefix=GFX9-FMAMIX %s
33
// RUN: not llvm-mc -triple=amdgcn -mcpu=gfx900 %s 2>&1 | FileCheck -check-prefix=GFX9-MADMIX-ERR --implicit-check-not=error: %s
4+
// RUN: not llvm-mc -triple=amdgcn -mcpu=gfx908 %s 2>&1 | FileCheck -check-prefix=GFX9-MADMIX-ERR --implicit-check-not=error: %s
5+
// RUN: not llvm-mc -triple=amdgcn -mcpu=gfx90a %s 2>&1 | FileCheck -check-prefix=GFX9-MADMIX-ERR --implicit-check-not=error: %s
6+
// RUN: not llvm-mc -triple=amdgcn -mcpu=gfx940 %s 2>&1 | FileCheck -check-prefix=GFX9-MADMIX-ERR --implicit-check-not=error: %s
47

58
v_fma_mix_f32 v0, v1, v2, v3
69
// GFX9-FMAMIX: v_fma_mix_f32 v0, v1, v2, v3 ; encoding: [0x00,0x00,0xa0,0xd3,0x01,0x05,0x0e,0x04]

0 commit comments

Comments
 (0)