Skip to content

Commit 548a9c3

Browse files
feedback
1 parent 0f25dce commit 548a9c3

File tree

1 file changed

+8
-0
lines changed

1 file changed

+8
-0
lines changed

llvm/docs/CIBestPractices.rst

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,11 @@ We choose to use ``github.repository_owner`` rather than ``github.repository``
3838
to enable these workflows to run in forks inside the LLVM organization such as
3939
the ClangIR fork.
4040

41+
There are some exceptions to this rule where ``github.repository`` might be
42+
used when it makes sense to limit a workflow to only running in the main
43+
monorepo repository. These include things like the issue subscriber and
44+
release tasks, which should not run anywhere else.
45+
4146
Hash Pinning Dependencies
4247
-------------------------
4348

@@ -56,6 +61,9 @@ just a release, which looks like the following:
5661
However, it is best practice to specify an exact commit SHA from which to pull
5762
the action from, noting the version in a comment:
5863

64+
We plan on revisting this reccomendation once Github's immutable actions have
65+
been rolled out as GA.
66+
5967
.. code-block:: yaml
6068
6169
steps:

0 commit comments

Comments
 (0)