Add comment

bharadwajy · bharadwajy · commit 54b1e873d18a · 2025-02-11T10:26:36.000-05:00
diff --git a/clang/lib/CodeGen/CGHLSLRuntime.cpp b/clang/lib/CodeGen/CGHLSLRuntime.cpp
@@ -345,6 +345,11 @@ void clang::CodeGen::CGHLSLRuntime::setHLSLEntryAttributes(
                 WaveSizeAttr->getPreferred());
     Fn->addFnAttr(WaveSizeKindStr, WaveSizeStr);
   }
+  // HLSL entry functions are materialized for module functions with
+  // HLSLShaderAttr attribute. SetLLVMFunctionAttributesForDefinition called
+  // later in the compiler-flow for such module functions is not aware of and
+  // hence not able to set attributes of the newly materialized entry functions.
+  // So, set attributes of entry function here, as appropriate.
   if (CGM.getCodeGenOpts().OptimizationLevel == 0) {
     Fn->addFnAttr(llvm::Attribute::OptimizeNone);
   }

Original file line number	Diff line number	Diff line change
`@@ -345,6 +345,11 @@ void clang::CodeGen::CGHLSLRuntime::setHLSLEntryAttributes(`
`345`	`345`	`WaveSizeAttr->getPreferred());`
`346`	`346`	`Fn->addFnAttr(WaveSizeKindStr, WaveSizeStr);`
`347`	`347`	`}`
	`348`	`+ // HLSL entry functions are materialized for module functions with`
	`349`	`+ // HLSLShaderAttr attribute. SetLLVMFunctionAttributesForDefinition called`
	`350`	`+ // later in the compiler-flow for such module functions is not aware of and`
	`351`	`+ // hence not able to set attributes of the newly materialized entry functions.`
	`352`	`+ // So, set attributes of entry function here, as appropriate.`
`348`	`353`	`if (CGM.getCodeGenOpts().OptimizationLevel == 0) {`
`349`	`354`	`Fn->addFnAttr(llvm::Attribute::OptimizeNone);`
`350`	`355`	`}`