feedback

Created using spr 1.3.7

Author: boomanaiden154

.ci/premerge_advisor_explain.py

@@ -60,7 +60,7 @@ def main(
        new comment containing the failure information and any possible premerge
        advisor findings.
     3. There has been a previous failure and the job passes - We update the
-       existing comment by passing its ID anda passed message to the
+       existing comment by passing its ID and a passed message to the
        issue-write workflow.
     4. There has been a previous failure and the job fails - We update the
        existing comment in the same manner as above, but generate the comment

.ci/utils.sh

@@ -38,7 +38,7 @@ function at-exit {
       $retcode "${BUILD_DIR}"/test-results.*.xml "${MONOREPO_ROOT}"/ninja*.log \
       >> $GITHUB_STEP_SUMMARY
     python "${MONOREPO_ROOT}"/.ci/premerge_advisor_explain.py \
-      $(git rev-parse HEAD~1) $retcode ${{ secrets.GITHUB_TOKEN }} \
+      $(git rev-parse HEAD~1) $retcode "${GITHUB_TOKEN}" \
       $GITHUB_PR_NUMBER "${BUILD_DIR}"/test-results.*.xml \
       "${MONOREPO_ROOT}"/ninja*.log
   fi

.github/workflows/premerge.yaml

@@ -64,6 +64,8 @@ jobs:
       - name: Build and Test
         timeout-minutes: 120
         continue-on-error: ${{ runner.arch == 'ARM64' }}
+        env:
+          GITHUB_TOKEN: ${{ github.token }}
         run: |
           git config --global --add safe.directory '*'
 
@@ -153,6 +155,8 @@ jobs:
         timeout-minutes: 180
         if: ${{ steps.vars.outputs.windows-projects != '' }}
         shell: cmd
+        env:
+          GITHUB_TOKEN: ${{ github.token }}
         run: |
           call C:\\BuildTools\\Common7\\Tools\\VsDevCmd.bat -arch=amd64 -host_arch=amd64
           # See the comments above in the Linux job for why we define each of