Skip to content

Commit 55edbe3

Browse files
author
mattarde
committed
update review comments
1 parent 1f7b326 commit 55edbe3

File tree

1 file changed

+6
-10
lines changed

1 file changed

+6
-10
lines changed

llvm/lib/Target/X86/X86ISelLowering.cpp

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -223,12 +223,6 @@ X86TargetLowering::X86TargetLowering(const X86TargetMachine &TM,
223223
setCondCodeAction(ISD::SETUNE, VT, Expand);
224224
}
225225

226-
if (Subtarget.hasAVX10_2()) {
227-
for (auto VT : {MVT::f32, MVT::f64}) {
228-
setCondCodeAction(ISD::SETOEQ, VT, Custom);
229-
setCondCodeAction(ISD::SETUNE, VT, Custom);
230-
}
231-
}
232226
// Integer absolute.
233227
if (Subtarget.canUseCMOV()) {
234228
setOperationAction(ISD::ABS , MVT::i16 , Custom);
@@ -2298,10 +2292,8 @@ X86TargetLowering::X86TargetLowering(const X86TargetMachine &TM,
22982292
setOperationAction(ISD::FP_EXTEND, MVT::f32, Legal);
22992293
setOperationAction(ISD::STRICT_FP_EXTEND, MVT::f32, Legal);
23002294

2301-
setCondCodeAction(ISD::SETOEQ, MVT::f16,
2302-
Subtarget.hasAVX10_2() ? Custom : Expand);
2303-
setCondCodeAction(ISD::SETUNE, MVT::f16,
2304-
Subtarget.hasAVX10_2() ? Custom : Expand);
2295+
setCondCodeAction(ISD::SETOEQ, MVT::f16, Expand);
2296+
setCondCodeAction(ISD::SETUNE, MVT::f16, Expand);
23052297

23062298
if (Subtarget.useAVX512Regs()) {
23072299
setGroup(MVT::v32f16);
@@ -2449,6 +2441,10 @@ X86TargetLowering::X86TargetLowering(const X86TargetMachine &TM,
24492441
setOperationAction(ISD::SETCC, VT, Custom);
24502442
}
24512443
}
2444+
for (auto VT : { MVT::f32, MVT::f64}) {
2445+
setCondCodeAction(ISD::SETOEQ, VT, Custom);
2446+
setCondCodeAction(ISD::SETUNE, VT, Custom);
2447+
}
24522448
}
24532449

24542450
if (!Subtarget.useSoftFloat() && Subtarget.hasVLX()) {

0 commit comments

Comments
 (0)