Sparc: Remove fishy VK_WPLT30 special case

MaskRay · MaskRay · commit 55fa7e1ef485 · 2025-05-03T23:05:23.000-07:00
I think 9fc2909 (2014) was misguided and added the unneeded special case. It probably wanted to handle R_SPARC_WPLT30/R_SPARC_WDISP30 in PDC/PIC but it's not correct to check the property in AsmParser.
diff --git a/llvm/lib/Target/Sparc/AsmParser/SparcAsmParser.cpp b/llvm/lib/Target/Sparc/AsmParser/SparcAsmParser.cpp
@@ -1480,8 +1480,6 @@ SparcAsmParser::parseSparcAsmOperand(std::unique_ptr<SparcOperand> &Op,
     if (getParser().parseExpression(EVal, E))
       break;
 
-    if (isCall && getContext().getObjectFileInfo()->isPositionIndependent())
-      EVal = SparcMCExpr::create(SparcMCExpr::VK_WPLT30, EVal, getContext());
     Op = SparcOperand::CreateImm(EVal, S, E);
     break;
   }

Original file line number	Diff line number	Diff line change
`@@ -1480,8 +1480,6 @@ SparcAsmParser::parseSparcAsmOperand(std::unique_ptr<SparcOperand> &Op,`
`1480`	`1480`	`if (getParser().parseExpression(EVal, E))`
`1481`	`1481`	`break;`
`1482`	`1482`
`1483`		`- if (isCall && getContext().getObjectFileInfo()->isPositionIndependent())`
`1484`		`- EVal = SparcMCExpr::create(SparcMCExpr::VK_WPLT30, EVal, getContext());`
`1485`	`1483`	`Op = SparcOperand::CreateImm(EVal, S, E);`
`1486`	`1484`	`break;`
`1487`	`1485`	`}`