Follow the review

Author: Camsyn

llvm/lib/Transforms/Utils/PredicateInfo.cpp

@@ -260,7 +260,8 @@ bool PredicateInfoBuilder::stackIsInScope(const ValueDFSStack &Stack,
   // next to the defs they must go with so that we can know it's time to pop
   // the stack when we hit the end of the phi uses for a given def.
   const ValueDFS &Top = *Stack.back().V;
-  if (Top.LocalNum == LN_Last && Top.PInfo) {
+  assert(Top.PInfo && "RenameStack should only contain predicate infos (defs)");
+  if (Top.LocalNum == LN_Last) {
     if (!VDUse.U) {
       assert(VDUse.PInfo && "A non-use VDUse should have a predicate info");
       // We should reserve adjacent LN_Last defs for the same phi use.

llvm/test/Transforms/SCCP/conditions-ranges.ll

@@ -1547,3 +1547,28 @@ bb2:
   call void @use(i1 %c4)
   ret void
 }
+
+define i1 @and_predicate_dominating_phi(i32 %x) {
+; CHECK-LABEL: @and_predicate_dominating_phi(
+; CHECK-NEXT:  entry:
+; CHECK-NEXT:    [[XGE1:%.*]] = icmp uge i32 [[X:%.*]], 1
+; CHECK-NEXT:    [[XLT2:%.*]] = icmp ult i32 [[X]], 2
+; CHECK-NEXT:    [[AND:%.*]] = and i1 [[XGE1]], [[XLT2]]
+; CHECK-NEXT:    br i1 [[AND]], label [[PHI:%.*]], label [[NOPE:%.*]]
+; CHECK:       nope:
+; CHECK-NEXT:    br label [[PHI]]
+; CHECK:       phi:
+; CHECK-NEXT:    ret i1 true
+;
+entry:
+  %xge1 = icmp uge i32 %x, 1
+  %xlt2 = icmp ult i32 %x, 2
+  %and = and i1 %xge1, %xlt2
+  br i1 %and, label %phi, label %nope
+nope:
+  br label %phi
+phi:
+  %res = phi i32 [ %x, %entry ], [ 1, %nope ]
+  %ret = icmp uge i32 %res, 1
+  ret i1 %ret
+}

llvm/test/Transforms/Util/PredicateInfo/testandor.ll

@@ -998,9 +998,9 @@ define void @test_assume_deep_and_tree(i1 %a1) {
 define i32 @test_and_with_phinode(i32 %x) {
 ; CHECK-LABEL: @test_and_with_phinode(
 ; CHECK-NEXT:  entry:
-; CHECK-NEXT:    [[XGT0:%.*]] = icmp uge i32 [[X:%.*]], 1
-; CHECK-NEXT:    [[XLT1:%.*]] = icmp ult i32 [[X]], 2
-; CHECK-NEXT:    [[AND:%.*]] = and i1 [[XGT0]], [[XLT1]]
+; CHECK-NEXT:    [[XGE1:%.*]] = icmp uge i32 [[X:%.*]], 1
+; CHECK-NEXT:    [[XLT2:%.*]] = icmp ult i32 [[X]], 2
+; CHECK-NEXT:    [[AND:%.*]] = and i1 [[XGE1]], [[XLT2]]
 ; CHECK:         [[X_0_1:%.*]] = bitcast i32 [[X]] to i32
 ; CHECK:         [[X_0_2:%.*]] = bitcast i32 [[X_0_1]] to i32
 ; CHECK-NEXT:    br i1 [[AND]], label [[PHI:%.*]], label [[NOPE:%.*]]
@@ -1011,9 +1011,9 @@ define i32 @test_and_with_phinode(i32 %x) {
 ; CHECK-NEXT:    ret i32 [[RES]]
 ;
 entry:
-  %xgt0 = icmp uge i32 %x, 1
-  %xlt1 = icmp ult i32 %x, 2
-  %and = and i1 %xgt0, %xlt1
+  %xge1 = icmp uge i32 %x, 1
+  %xlt2 = icmp ult i32 %x, 2
+  %and = and i1 %xge1, %xlt2
   br i1 %and, label %phi, label %nope
 nope:
   br label %phi