Add FIXME

thurstond · thurstond · commit 5789cca9258b · 2024-11-13T21:12:56.000Z
diff --git a/compiler-rt/lib/sanitizer_common/sanitizer_linux.cpp b/compiler-rt/lib/sanitizer_common/sanitizer_linux.cpp
@@ -169,6 +169,7 @@ void SetSigProcMask(__sanitizer_sigset_t *set, __sanitizer_sigset_t *oldset) {
 // Equivalently: newset[signum] = newset[signum] & oldset[signum]
 static void KeepUnblocked(__sanitizer_sigset_t &newset,
                           __sanitizer_sigset_t &oldset, int signum) {
+  // FIXME: this causes mysterious failures on Android
   if (SANITIZER_ANDROID || !internal_sigismember(&oldset, signum))
     internal_sigdelset(&newset, signum);
 }

Original file line number	Diff line number	Diff line change
`@@ -169,6 +169,7 @@ void SetSigProcMask(__sanitizer_sigset_t set, __sanitizer_sigset_t oldset) {`
`169`	`169`	`// Equivalently: newset[signum] = newset[signum] & oldset[signum]`
`170`	`170`	`static void KeepUnblocked(__sanitizer_sigset_t &newset,`
`171`	`171`	`__sanitizer_sigset_t &oldset, int signum) {`
	`172`	`+ // FIXME: this causes mysterious failures on Android`
`172`	`173`	`if (SANITIZER_ANDROID \|\| !internal_sigismember(&oldset, signum))`
`173`	`174`	`internal_sigdelset(&newset, signum);`
`174`	`175`	`}`