setting up variables

Author: Jaddyen

mlir/include/mlir/Dialect/EmitC/IR/EmitC.td

@@ -1191,10 +1191,10 @@ def EmitC_VariableOp : EmitC_Op<"variable", []> {
   }];
 
   let arguments = (ins EmitC_OpaqueOrTypedAttr:$value);
-  let results = (outs Res<AnyTypeOf<[EmitC_ArrayType, EmitC_LValueType]>, "",
-                          [MemAlloc<DefaultResource, 0, FullEffect>]>);
+  let results = (outs Res<AnyTypeOf<[EmitCType]>,
+                          "", [MemAlloc<DefaultResource, 0, FullEffect>]>);
 
-  let hasVerifier = 1;
+  // let hasVerifier = 1;
 }
 
 def EmitC_GlobalOp : EmitC_Op<"global", [Symbol]> {

mlir/lib/Conversion/MemRefToEmitC/MemRefToEmitC.cpp

@@ -316,13 +316,15 @@ struct ConvertExtractStridedMetadata final
     auto baseptr =
         cast<MemRefType>(extractStridedMetadataOp.getBaseBuffer().getType());
     auto emitcType = convertMemRefType(baseptr, getTypeConverter());
-
+    auto arrT = emitc::ArrayType::get(memrefType.getShape(), emitcType);
+    auto valVar = rewriter.create<emitc::VariableOp>(
+        loc, arrT, emitc::OpaqueAttr::get(rewriter.getContext(), ""));
     auto [strides, offset] = memrefType.getStridesAndOffset();
     Value offsetValue = rewriter.create<emitc::ConstantOp>(
         loc, rewriter.getIndexType(), rewriter.getIndexAttr(offset));
 
     SmallVector<Value> results;
-    results.push_back(extractStridedMetadataOp.getBaseBuffer());
+    results.push_back(valVar);
     results.push_back(offsetValue);
 
     for (unsigned i = 0, e = memrefType.getRank(); i < e; ++i) {

mlir/lib/Dialect/EmitC/IR/EmitC.cpp

@@ -889,9 +889,9 @@ LogicalResult SubOp::verify() {
 // VariableOp
 //===----------------------------------------------------------------------===//
 
-LogicalResult emitc::VariableOp::verify() {
-  return verifyInitializationAttribute(getOperation(), getValueAttr());
-}
+// LogicalResult emitc::VariableOp::verify() {
+//   return verifyInitializationAttribute(getOperation(), getValueAttr());
+// }
 
 //===----------------------------------------------------------------------===//
 // YieldOp